don't flag that a model has changes unless the values have actually c…

…hanged from the originals
team23 · Nov 6, 2023 · 2ee9e9c · 2ee9e9c
1 parent d395b7b
commit 2ee9e9c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/pydantic_changedetect/changedetect.py b/pydantic_changedetect/changedetect.py
@@ -221,7 +221,8 @@ def __setattr__(self, name, value) -> None:  # noqa: ANN001
         if name in self_compat.model_fields and name not in self.model_original:
             self.model_original[name] = self.__dict__[name]
         super().__setattr__(name, value)
-        self.model_self_changed_fields.add(name)
+        if self.model_original[name] != value:
+            self.model_self_changed_fields.add(name)
 
     def __getstate__(self) -> Dict[str, Any]:
         state = super().__getstate__()

diff --git a/tests/test_changedetect.py b/tests/test_changedetect.py
@@ -70,6 +70,14 @@ def test_set_changed_state():
     assert obj.model_changed_fields == {"id"}
 
 
+def test_values_did_not_change():
+    obj = Something(id=1)
+    assert not obj.model_has_changed
+    obj.id = 1
+    assert not obj.model_has_changed
+    assert obj.model_changed_fields == set()
+
+
 def test_set_changed_state_with_fixed_original():
     obj = Something(id=1)