Redirect user to homepage after login or signup #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShelbsH
suggested changes
Jul 17, 2021
Comment on lines
+6
to
+12
| test("pages renders correctly", () => { | ||
| const {queryByLabelText, queryByRole} = render(<Signup/>); | ||
| expect(queryByLabelText("Email")).toBeTruthy(); | ||
| expect(queryByLabelText("Password")).toBeTruthy(); | ||
| expect(queryByRole("button")).toBeVisible(); | ||
| //TODO: check if button is rendered. | ||
| }); |
There was a problem hiding this comment.
If you're just testing if elements are rendered into the DOM, you can use the same methods from screen. This avoids having to keep using destructuring queries from render(...). Kent Dodds talks about it here.
Since you're using jest-dom, you could change .toBeTruthy() to be toBeInTheDocument(), since it's a little more accurate in stating that those elements are rendered. The same for the button as well.
vijayxtreme
approved these changes
Jul 18, 2021
|
Please use "squash and merge" when you are finished so we can roll all these updates into one commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.