Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all the warning of the issue no#628 #643

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arunsak04
Copy link

In this refactored code:(DebMojo.java)

Generics are used where applicable to make the code type-safe.
Unchecked or unsafe operations are addressed.
Warnings are suppressed only when necessary.
Some code optimizations and improvements are made

In this refactored code:(OutputTimestampResolver.java)

We use java.time.Instant to represent a point in time.
We convert the output date to an Instant, then to milliseconds since the epoch using toEpochMilli() method.
We use java.time.LocalDateTime instead of Date for parsing the output timestamp, and convert it to an Instant.
We use TimeUnit.SECONDS.toMillis() for converting seconds to milliseconds when reading from the environment variable.

@arunsak04 arunsak04 changed the title Fixed all the warning Fixed all the warning of the issue no#628 Mar 27, 2024
@tcurdt
Copy link
Owner

tcurdt commented Apr 8, 2024

Thanks for the contribution.

A few notes:
The re-formatting makes it quite hard to follow though. Re-formatting should better be kept in a separate PR.
Also I am not sure why you thought to remove javadocs.
And as you can see the CI is failing.

@tcurdt
Copy link
Owner

tcurdt commented Apr 28, 2024

Could you please revert the reformatting and rebase. It's too hard to review the PR like this.

Repository owner deleted a comment Jun 4, 2024
Repository owner deleted a comment Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants