Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #181 #184

Merged
merged 3 commits into from
Feb 15, 2015
Merged

Fixes Issue #181 #184

merged 3 commits into from
Feb 15, 2015

Conversation

stevenbower
Copy link
Contributor

This fixes issue #181. This adds a new property called "propertyPrefix" which when set will populate 7 variables with the deb name, path, changes name, path and version number. This is needed for other plugins to be able to access these files (for example wagon, etc..)

@ebourg
Copy link
Collaborator

ebourg commented Oct 1, 2014

Is it really necessary to have a configurable prefix? What about using a default prefix like jdeb.<groupId>.<artifactId> instead?

@tcurdt
Copy link
Owner

tcurdt commented Oct 1, 2014

I would be OK to merge this - but I have the same question as @ebourg.

@stevenbower
Copy link
Contributor Author

There reason for a configurable prefix is if you need to generate multiple deb files within a single artifact.. this way you can reference either..

@tcurdt
Copy link
Owner

tcurdt commented Oct 11, 2014

Hm - AFAIK it's not exactly encouraged (to put it mildly) to even be generating multiple artifacts with maven. Or did that change? Is it an open source project where you show the pom?

@stevenbower
Copy link
Contributor Author

I'm not hell bent on having the prefix (it could just be a boolean or just be on all the time).. but there are use cases for this... and I decided to make it work this way because you can always have multiple executions of the same plugin... One way we could alter the patch would be to just default this to on and set the default prefix to "jdeb." and then for the 90th percentile use case it would be standardized.. if you like this idea let me know and I can code it up..

Btw, this is not an open source project..

@tcurdt tcurdt added this to the 1.4 milestone Dec 15, 2014
tcurdt added a commit that referenced this pull request Feb 15, 2015
provide information about the build back to maven, fixes Issue #181
@tcurdt tcurdt merged commit de30000 into tcurdt:master Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants