Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mise en place certificate pinning #1

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

yostyle
Copy link

@yostyle yostyle commented Aug 10, 2024

Content

Add certificate pinning feature only on Gplay release build.

Motivation and context

tchapgouv/tchap-product#373

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@yostyle yostyle self-assigned this Aug 10, 2024
@yostyle yostyle changed the title Add certificate pinning security Ajout du certificate pinning dans Tchap X Aug 12, 2024
@yostyle yostyle added the PR-Feature For a new feature label Aug 12, 2024
@yostyle yostyle marked this pull request as ready for review August 12, 2024 09:20
Copy link

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does F-Droid version need to allow clear traffic on local network ? VPN need on NEO devices ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear text traffic can be used only for specific hosts during development :

  • localhost
  • 127.0.0.1
  • etc ...

It's the default configuration provided by Element X for all variants (Fdroid and Gplay). I move it for Fdroid only.

@yostyle yostyle changed the title Ajout du certificate pinning dans Tchap X Ajout du certificate pinning Aug 29, 2024
@yostyle yostyle changed the title Ajout du certificate pinning Mise en place certificate pinning Aug 29, 2024
@yostyle yostyle merged commit 75b604e into develop Aug 29, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants