Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to neutralize/restore feebleline #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

p1llule
Copy link

@p1llule p1llule commented Mar 9, 2021

Hi tautologyclub,

Feebleline is not the only package to use extensively the echo area.
visual-regexp also does and have conflicts with feebleline.

Theses functions, deactivate feebleline without altering the mode state.
They can patch conflicts if used in hooks like :

   (add-hook 'vr/initialize-hook #'initialize-without-feebleline)
   (add-hook 'vr/end-hook #'end-with-feebleline)

See benma/visual-regexp.el#60

p1llule added 2 commits March 9, 2021 01:41
Feebleline is not the only package to use extensively the echo area.
visual-regexp also does and have conflicts with feebleline.

Theses functions, deactivate feebleline without altering the mode state.
They can patch conflicts used in hooks like :

       (add-hook 'vr/initialize-hook #'initialize-without-feebleline)
       (add-hook 'vr/end-hook #'end-with-feebleline)

See benma/visual-regexp.el#60
I suppose I was concerned to the possibility to end up with a butchered
state and has set a check this variable ; but if the hooks are correctly
applied (in an unwind-protect form), there is no need to takes extra steps.
cjennings added a commit to cjennings/feebleline that referenced this pull request Apr 27, 2024
- Add functions to neutralize/restore feebleline tautologyclub#64
  tautologyclub@4c3d83e
cjennings added a commit to cjennings/feebleline that referenced this pull request Apr 27, 2024
Patches
- add requirement on subr-x
- changed function name in patch 64 from 'intialize-without-feebleline' and
  'end-with-feebleline' to feebleline-disable and feebleline-reenable
- Add functions to neutralize/restore feebleline tautologyclub#64
  tautologyclub@4c3d83e
- Do not get git branch on tramp files or buffers without a file tautologyclub#65
  tautologyclub@dedb5e3

Bug Fixes
- fix alignment code and default to left if alignment not specified
- require 'cl-lib rather than 'cl-macs
- add defgroup for customization

Reorganization
- move custom variables, faces, and other constants to top
- move feebleline-disable and feebleline-reenable to bottom of code
  after feebleline-mode is defined to avoid undefined variable issues

Misc
- add SPDX-License-Identifier for GPL-3.0-or-later
- add requires Emacs 25.1 for project and window divider functionality
- add feebleline-file-or-buffer-face face
- nearly all documentation strings improved many missing ones added
- remove all stray disabled code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant