Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve counsel-term-cd, add counsel-eshell-cd #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mnewt
Copy link

@mnewt mnewt commented Sep 15, 2019

Hello @tautologyclub,

Great library, thanks for sharing! Mind if I help you give it some polish? I updated the logic for counsel-term-cd to be a little more efficient and list direct children of the current directory when the input characters are less than two. Hope you agree it's an improvement. Also added an analogous command for Eshell and updated a couple things, like moving from counsel-more-chars to ivy-more-chars.

Cheers!

@tautologyclub
Copy link
Owner

tautologyclub commented Sep 18, 2019

Hi, thanks!

I certainly don't mind. I haven't really touched this lib in AGES - I use counsel-term-history all the time but I kinda forgot the other features even existed. I think your improvements sounds great tho.

HOWEVER, they don't work for me. I just get an error code when attempting counsel-term-cd.

@tautologyclub
Copy link
Owner

It looks like your syntax is wrong on "find type d " call.

@mnewt
Copy link
Author

mnewt commented Sep 20, 2019

Yeah that was sloppy, I must have only tested fd at the end. Sorry about that.

find and fd have annoyingly similar but incompatible syntaxes. It's worth it though because the speed difference is crazy. Over a large directoary structure it might mean the difference between a few seconds and a few minutes.

Feedback welcome. I don't have a ton of time to spend on this but it's fun to give back!

@tautologyclub
Copy link
Owner

I'll get on this as soon as I got the chance, and will check out fd as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants