Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional logging; update example app #44

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add optional logging; update example app #44

merged 2 commits into from
Sep 17, 2024

Conversation

dmoss18
Copy link
Contributor

@dmoss18 dmoss18 commented Sep 13, 2024 •
edited
Loading

This is a breaking change, as it breaks the TastytradeClient constructor. I need to add some notes to the changelog and update the README

Addresses #43

@dmoss18 dmoss18 marked this pull request as ready for review September 17, 2024 19:24
@dmoss18 dmoss18 merged commit 23ac561 into master Sep 17, 2024
4 checks passed
@dmoss18 dmoss18 deleted the logging-with-examples branch September 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmoss18