Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(movies): update to ng17, rxa 17, eslint #280

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
d184836
refactor(movies): update packages
BioPhoton Nov 12, 2023
f4bd4db
refactor(movies): refactor to latest rxA
BioPhoton Nov 12, 2023
b12bf20
refactor(movies): fix package.json overwrites
BioPhoton Nov 12, 2023
108b2d2
refactor(movies): fix effect
BioPhoton Nov 12, 2023
13b5544
refactor(movies): fix effect 2
BioPhoton Nov 12, 2023
86d66b2
refactor(movies): use afterNextRender
BioPhoton Nov 12, 2023
0194669
refactor(movies): nx format
BioPhoton Nov 12, 2023
f2e3182
refactor(movies): remove user-flows
BioPhoton Nov 12, 2023
80e0c80
refactor(movies): remove ngswConfigPath prop
BioPhoton Nov 12, 2023
5b01dfe
refactor(movies): actions 1
BioPhoton Nov 12, 2023
18fa551
refactor(movies): update user flow
BioPhoton Nov 12, 2023
ed7789d
chore(movies): start command in package.json was broken
eneajaho Nov 12, 2023
c1f9c61
refactor(movies): convert to new template syntax
eneajaho Nov 12, 2023
870000f
refactor(movies): remove trackByIndex
JeanMeche Nov 13, 2023
1c19e5e
refactor(movies): update deps
JeanMeche Jan 26, 2024
326e05b
chore: fix typo in readme (#283)
manniL Mar 2, 2024
b628f8a
Update README.md (#284)
BioPhoton Mar 3, 2024
97a59d2
refactor(movies): migrate to use application builder SSR features
eneajaho Nov 13, 2023
6ea4c62
chore(movies): update dependencies for fix start
JeanMeche Jan 29, 2024
3bc20b9
refactor(movies): rxState migration property access before declared
vmasek Mar 4, 2024
dc821d6
refactor(movies): rename commintlint config suffix to keep it using c…
vmasek Mar 4, 2024
0e8448e
refactor(movies): update to node 20
vmasek Mar 5, 2024
49b2022
refactor(movies): update firebase packages
vmasek Mar 5, 2024
fd73ed9
refactor(movies): merge two firebase configurations
vmasek Mar 6, 2024
bcdbd45
refactor(movies): migrate functions to esbuild
vmasek Mar 6, 2024
ffde274
refactor(movies): remove local run that executes by default and messe…
vmasek Mar 6, 2024
6afaf5f
refactor(movies): package lock after merge
vmasek Mar 6, 2024
13780e3
feat: use defer block, convert to signals, fix icons in ssr, update v…
eneajaho Mar 8, 2024
4f1cab1
fix: comment out server.ts run part
eneajaho Mar 8, 2024
550897a
fix: enable prerendering
eneajaho Mar 8, 2024
b97d0a8
fix: remove unused ci workflows
eneajaho Mar 8, 2024
c998cac
Merge pull request #281 from tastejs/update-to-ng17-ssr
eneajaho Mar 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/firebase-function-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ jobs:
- name: User Flow
run: npm run nx run firebase-function:user-flow:production -- --format=md

- name: Test firebase function emulation
id: firebase-function-emulation
uses: push-based/[email protected]
with:
verbose: on
commentId: test-firebase-function--deploy-emulation
onlyComments: on
outPath: ./dist/user-flow/firebase-function
rcPath: projects/firebase-function/.user-flowrc.json
#- name: Test firebase function emulation
# id: firebase-function-emulation
# uses: push-based/[email protected]
# with:
# verbose: on
# commentId: test-firebase-function--deploy-emulation
# onlyComments: on
# outPath: ./dist/user-flow/firebase-function
# rcPath: projects/firebase-function/.user-flowrc.json
22 changes: 11 additions & 11 deletions .github/workflows/firebase-hosting-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@ jobs:
env:
FIREBASE_CLI_PREVIEWS: hostingchannels

- name: User Flow
run: npm run nx run movies:user-flow:production -- --format=md --url=${{ fromJson(steps.previewDeployStep.outputs.urls)[0] }}
# - name: User Flow
# run: npm run nx run movies:user-flow:production -- --format=md --url=${{ fromJson(steps.previewDeployStep.outputs.urls)[0] }}

- name: Test firebase preview channel hosting
id: firebase-preview-channel-hosting
uses: push-based/[email protected]
with:
verbose: on
commentId: firebase-preview-channel-hosting
onlyComments: on
outPath: ./dist/user-flow/movies
rcPath: ./projects/movies/.user-flowrc.json
#- name: Test firebase preview channel hosting
# id: firebase-preview-channel-hosting
# uses: push-based/[email protected]
# with:
# verbose: on
# commentId: firebase-preview-channel-hosting
# onlyComments: on
# outPath: ./dist/user-flow/movies
# rcPath: ./projects/movies/.user-flowrc.json

2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,5 @@ testem.log
Thumbs.db

.angular

.nx/cache
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ dist
coverage

.angular

/.nx/cache
151 changes: 138 additions & 13 deletions migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,152 @@
"migrations": [
{
"cli": "nx",
"version": "16.6.0-beta.6",
"description": "Prefix outputs with {workspaceRoot}/{projectRoot} if needed",
"implementation": "./src/migrations/update-15-0-0/prefix-outputs",
"version": "16.8.0-beta.3",
"description": "Escape $ in env variables",
"implementation": "./src/migrations/update-16-8-0/escape-dollar-sign-env-variables",
"package": "nx",
"name": "16.6.0-prefix-outputs"
"name": "16.8.0-escape-dollar-sign-env"
},
{
"cli": "nx",
"version": "16.6.0-beta.0",
"description": "Explicitly set 'updateBuildableProjectDepsInPackageJson' to 'true' in targets that rely on that value as the default.",
"factory": "./src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps",
"package": "@nx/js",
"name": "explicitly-set-projects-to-update-buildable-deps"
"version": "17.0.0-beta.1",
"description": "Updates the default cache directory to .nx/cache",
"implementation": "./src/migrations/update-17-0-0/move-cache-directory",
"package": "nx",
"name": "17.0.0-move-cache-directory"
},
{
"cli": "nx",
"version": "17.0.0-beta.3",
"description": "Use minimal config for tasksRunnerOptions",
"implementation": "./src/migrations/update-17-0-0/use-minimal-config-for-tasks-runner-options",
"package": "nx",
"name": "17.0.0-use-minimal-config-for-tasks-runner-options"
},
{
"version": "17.0.0-rc.1",
"description": "Migration for v17.0.0-rc.1",
"implementation": "./src/migrations/update-17-0-0/rm-default-collection-npm-scope",
"package": "nx",
"name": "rm-default-collection-npm-scope"
},
{
"version": "17.1.0-beta.2",
"description": "Move jest executor options to nx.json targetDefaults",
"implementation": "./src/migrations/update-17-1-0/move-options-to-target-defaults",
"package": "@nx/jest",
"name": "move-options-to-target-defaults"
},
{
"cli": "nx",
"version": "16.7.0-beta.6",
"requires": {
"@angular/core": ">=16.2.0"
},
"description": "Update the @angular/cli package version to ~16.2.0.",
"factory": "./src/migrations/update-16-7-0/update-angular-cli",
"package": "@nx/angular",
"name": "update-angular-cli-version-16-2-0"
},
{
"cli": "nx",
"version": "17.1.0-beta.5",
"requires": {
"@angular/core": ">=17.0.0"
},
"description": "Update the @angular/cli package version to ~17.0.0.",
"factory": "./src/migrations/update-17-1-0/update-angular-cli",
"package": "@nx/angular",
"name": "update-angular-cli-version-17-0-0"
},
{
"cli": "nx",
"version": "17.1.0-beta.5",
"requires": {
"@angular/core": ">=17.0.0"
},
"description": "Rename 'browserTarget' to 'buildTarget'.",
"factory": "./src/migrations/update-17-1-0/browser-target-to-build-target",
"package": "@nx/angular",
"name": "rename-browser-target-to-build-target"
},
{
"cli": "nx",
"version": "17.1.0-beta.5",
"requires": {
"@angular/core": ">=17.0.0"
},
"description": "Replace usages of '@nguniversal/builders' with '@angular-devkit/build-angular'.",
"factory": "./src/migrations/update-17-1-0/replace-nguniversal-builders",
"package": "@nx/angular",
"name": "replace-nguniversal-builders"
},
{
"cli": "nx",
"version": "17.1.0-beta.5",
"requires": {
"@angular/core": ">=17.0.0"
},
"description": "Replace usages of '@nguniversal/' packages with '@angular/ssr'.",
"factory": "./src/migrations/update-17-1-0/replace-nguniversal-engines",
"package": "@nx/angular",
"name": "replace-nguniversal-engines"
},
{
"cli": "nx",
"version": "16.6.0-beta.0",
"description": "Explicitly set 'updateBuildableProjectDepsInPackageJson' to 'true' in targets that rely on that value as the default.",
"factory": "./src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps",
"version": "17.1.0-beta.5",
"requires": {
"@angular/core": ">=17.0.0"
},
"description": "Replace the deep imports from 'zone.js/dist/zone' and 'zone.js/dist/zone-testing' with 'zone.js' and 'zone.js/testing'.",
"factory": "./src/migrations/update-17-1-0/update-zone-js-deep-import",
"package": "@nx/angular",
"name": "explicitly-set-projects-to-update-buildable-deps"
"name": "update-zone-js-deep-import"
},
{
"cli": "nx",
"version": "16.8.2-beta.0",
"description": "Remove invalid options (strict, noInterop) for ES6 type modules.",
"factory": "./src/migrations/update-16-8-2/update-swcrc",
"package": "@nx/js",
"name": "16-8-2-update-swcrc"
},
{
"cli": "nx",
"version": "17.0.2",
"description": "Remove deprecated build options",
"implementation": "./src/migrations/update-17-0-0/remove-deprecated-build-options",
"package": "@nx/js",
"name": "update-17-0-0-remove-deprecated-build-options"
},
{
"cli": "nx",
"version": "16.9.0-beta.1",
"description": "Replace imports of Module Federation utils frm @nx/devkit to @nx/webpack",
"implementation": "./src/migrations/update-16-9-0/migrate-mf-util-usage",
"package": "@nx/devkit",
"name": "update-16-9-0-migrate-mf-usage-to-webpack"
},
{
"version": "17.0.0",
"description": "Angular v17 introduces a new control flow syntax that uses the @ and } characters. This migration replaces the existing usages with their corresponding HTML entities.",
"factory": "./migrations/block-template-entities/bundle",
"package": "@angular/core",
"name": "block-template-entities"
},
{
"version": "17.0.0",
"description": "CompilerOption.useJit and CompilerOption.missingTranslation are unused under Ivy. This migration removes their usage",
"factory": "./migrations/compiler-options/bundle",
"package": "@angular/core",
"name": "migration-v17-compiler-options"
},
{
"version": "17.0.0",
"description": "Updates `TransferState`, `makeStateKey`, `StateKey` imports from `@angular/platform-browser` to `@angular/core`.",
"factory": "./migrations/transfer-state/bundle",
"package": "@angular/core",
"name": "migration-transfer-state"
}
]
}
5 changes: 0 additions & 5 deletions nx.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
{
"tasksRunnerOptions": {
"default": {
"runner": "nx-cloud"
}
},
"affected": {
"defaultBase": "origin/main"
},
Expand Down
Loading
Loading