Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task patterns #257

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Conversation

stinovlas
Copy link
Contributor

Closes #256.

As per #256, i changed the rglob pattern search to glob and added a possibility to specify --tasks-pattern option multiple times.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11bebcc) 77.20% compared to head (e8a9d07) 77.31%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
+ Coverage    77.20%   77.31%   +0.11%     
===========================================
  Files           60       60              
  Lines         1750     1750              
===========================================
+ Hits          1351     1353       +2     
+ Misses         399      397       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s3rius
Copy link
Member

s3rius commented Dec 6, 2023

Actually I like the approach, because it will make it task searching more flexible. I will update minor version because of this PR, Since it might break apps that were using custom --tasks-pattern.

@stinovlas stinovlas marked this pull request as draft December 6, 2023 16:30
@stinovlas
Copy link
Contributor Author

I still have to make some corrections in import_tasks and I'd also like to write a test for it. I'll drop the draft status when the PR is ready :-).

@s3rius
Copy link
Member

s3rius commented Dec 6, 2023

Also, can you make import_tasks to accept either sequence or string as pattern? Because I was using this function in some taskiq-related third-party libs.

@stinovlas stinovlas marked this pull request as ready for review December 7, 2023 11:23
@stinovlas
Copy link
Contributor Author

Also, can you make import_tasks to accept either sequence or string as pattern? Because I was using this function in some taskiq-related third-party libs.

Sure, done :-). I added some tests and believe that the PR is ready for review.

@s3rius s3rius merged commit 6bd1550 into taskiq-python:develop Dec 11, 2023
23 checks passed
@s3rius
Copy link
Member

s3rius commented Dec 11, 2023

Thank you very much for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks pattern includes .tox and other directories
3 participants