Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: mocktwilio refactor #2602

Draft
wants to merge 54 commits into
base: master
Choose a base branch
from
Draft

dev: mocktwilio refactor #2602

wants to merge 54 commits into from

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Aug 29, 2022 •
edited
Loading

Description:
This PR makes several changes in the mocktwilio devtool to make it more usable as a standalone package.

  • Assertions & interfaces are now part of the package itself (instead of in the harness)
  • behavior is much more deterministic, and smoke tests run up to 4x faster in some cases
  • interfaces were adjusted to represent better user options (to allow for UI in future PR)
  • no longer depends on goalert packages (standalone)
  • XML parsing/handling rather than relying on string scraping
  • more explicit API for assertions, calls no longer call the application before being answered
  • support for full TwiML flows (but only supported verbs)

Which issue(s) this PR fixes:
Part of #2633

@mastercactapus
rewrite mocktwilio with assertions
1784ebb
@mastercactapus
add numbers after startup
11e5bd3
@mastercactapus
update harness to use mocktwilio package for assertions
6fc65e1
@mastercactapus
fix server
243efa5
@mastercactapus
add simple functionality test
4c02a8b
@mastercactapus
add post message to db
5317ab6
@mastercactapus
test additional endpoints
5b35c9c
@mastercactapus
fix startup race
ca42364
@mastercactapus
put date in url
4c1b658
@mastercactapus
add better logs
251f46a
@mastercactapus
fix fast-forward time
88e6e20
@mastercactapus
clairify message output
53c4a88
@mastercactapus
fix waitandassert
6b9059c
@mastercactapus
code organization
cae20fc
@mastercactapus
init routes
4aca25b
@mastercactapus
handle call routing
cd94238
@mastercactapus
post call status updates
a854a18
@mastercactapus
twiml package
86a7433
@mastercactapus
add verbs
7d4e1d4
@mastercactapus
add type safe interfaces
e876fcb
@mastercactapus
call state handling
f7a9f3f
@mastercactapus
fix name conflict
4996cde
@mastercactapus
relative url handling
be60927
@mastercactapus
track invalid urls
79747d1
@mastercactapus
voice server test
12fe6ee
@mastercactapus
Merge remote-tracking branch 'origin/master' into mocktwilio-refactor
4fd8663
@mastercactapus
fix message service handling
76dba6a
@mastercactapus
include url and data in error
52ab665
@mastercactapus
use correct method for fetching voice status
76eb335
@mastercactapus
call status
31b708b
@mastercactapus
Copy link
Member Author

  • validate start/stop tests (esp. with message SID)

This was referenced Sep 27, 2022
Closed
Open
@stale
Copy link

stale bot commented Oct 29, 2022

This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale This is inactive label Oct 29, 2022
@stale stale bot removed the stale This is inactive label Nov 21, 2022
@stale
Copy link

stale bot commented Jan 16, 2023

This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale This is inactive label Jan 16, 2023
This was referenced Mar 24, 2023
Merged
Merged
Merged
@mastercactapus mastercactapus marked this pull request as draft March 29, 2023 18:40
@stale stale bot removed the stale This is inactive label Mar 29, 2023
@stale
Copy link

stale bot commented May 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale This is inactive label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale This is inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mastercactapus