fifottl: fix release/bury next_event setup #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`take` sets up the next event time as current time + `ttr`, while `release` and `bury` do not update the next event time. This can lead to a task being deleted after `take time` + `ttr` after `release` or `bury` in the queue fiber. To fix the issue we can copy approach from the `queue` module [1][2]. 1. https://github.com/tarantool/queue/blob/481b5fbf47a7db5c504c64a688b4f8a5fc765a45/queue/abstract/driver/fifottl.lua#L348-L351 2. https://github.com/tarantool/queue/blob/481b5fbf47a7db5c504c64a688b4f8a5fc765a45/queue/abstract/driver/fifottl.lua#L367-L370 Closes #65
Pull Request Test Coverage Report for Build 6094473688
💛 - Coveralls |
better0fdead
approved these changes
Sep 6, 2023
LeonidVas
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
takesets up the next event time as current time +ttr, whilereleaseandburydo not update the next event time. This can lead to a task being deleted aftertake time+ttrafterreleaseorburyin the queue fiber.To fix the issue we can copy approach from the
queuemodule [1][2].Closes #65