-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add the role implementation #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-6-role-implementation
branch
from
July 9, 2024 13:28
4b84ec4
to
5cfab2d
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-6-role-implementation
branch
from
July 9, 2024 13:33
5cfab2d
to
9d6d180
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-6-role-implementation
branch
7 times, most recently
from
July 10, 2024 06:58
c583fb7
to
707dc32
Compare
DifferentialOrange
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems cool, thank you!
The role is generally similar in functionality to `cartridge-metrics-role`. But there is also a difference. The key difference - the role does not support `health` format. The role name is `roles.metrics-export` it could be configured in the Tarantool 3 cluster configuration like this: ```yaml roles: [roles.metrics-export] roles_cfg: roles.metrics-export: http: - listen: 8081 endpoints: - path: /metrics/json format: json - path: /metrics/prometheus/ format: prometheus - listen: '127.0.0.1:8082' endpoints: - path: /metrics/prometheus format: prometheus - path: /metrics/json/ format: json ``` * `http` - is an export type name. The `http` is only supported at now. It allows to export metrics via a list of HTTP servers. * `listen` - is an address/port to listen via a HTTP server. * `endpoints` - is a list of endpoints to share via the HTTP server. * `path` - is an endpoint path. * `format` - is an export format for the endpoint, at now the role supports only `json` and `prometheus`. Closes #6
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-6-role-implementation
branch
from
July 10, 2024 08:44
707dc32
to
69c7606
Compare
better0fdead
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thx for patch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role is generally similar in functionality to
cartridge-metrics-role
. But there is also a difference. The key difference - the role does not supporthealth
format.The role name is
roles.metrics-export
it could be configured in the Tarantool 3 cluster configuration like this:http
- is an export type name. Thehttp
is only supported at now. It allows to export metrics via a list of HTTP servers.listen
- is an address/port to listen via a HTTP server.endpoints
- is a list of endpoints to share via the HTTP server.path
- is an endpoint path.format
- is an export format for the endpoint, at now the role supports onlyjson
andprometheus
.Closes #6