Try to rebase 3.10.0 #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/luarocks-3.10.0-rebase
branch
from
3121d38
to
8fbbd14
Compare
(cherry picked from commit c2c0272)
oleg-jukovec
force-pushed
the
oleg-jukovec/luarocks-3.10.0-rebase
branch
from
8fbbd14
to
3668089
Compare
There are some problems on macos-13 and we don't interesting in the coverate for the repo.
* Skip external commands loading if no external_namespace provided: it is so when a command is run using `tarantoolctl rocks <command>`. * Allow to omit a description field in a rockspec. * Configure more options using hardcoded.lua (it is named as site_config.lua in luarocks-2.x). Based on or inspired by the following commits: - 9f55766 ('Add LUAROCKS_LOCAL_BY_DEFAULT option to site_config.lua'). - e3f7486 ('Allow to override certain values in cfg.lua'). - dba49e0 ('Enable cfg.home_tree even for root'). - 6e6fe62 ('Add site_config.LUAROCKS_LOCALDIR config variable'). The following options are added for hardcoded.lua: - LOCALDIR - LOCAL_BY_DEFAULT - HOMEDIR - HOME_TREE_SUBDIR - LUA_MODULES_LUA_SUBDIR - LUA_MODULES_LIB_SUBDIR - ROCKS_SERVERS The following options are ported from luarocks-2 (and renamed from LUAROCKS_FOO to FOO): - ROCKS_SUBDIR - EXTERNAL_DEPS_SUBDIRS All that options are needed to adjust behaviour of luarocks from tarantool-side hardcoded.lua file. * Detect tarantool and add it to rocks_provided and rocks_provided_3_0. Based on: - 370d173 ('Detect and add Tarantool it to rocks_provided)' * Execute cfg.init() code only once. * Fixed strict mode. Inspired by: - dfaf765 ('Fix strict mode'). * Dropped site_config.lua support: tarantool doesn't use it anymore.
oleg-jukovec
force-pushed
the
oleg-jukovec/luarocks-3.10.0-rebase
branch
2 times, most recently
from
9c8b118
to
4e8827d
Compare
The success include that cfg.variables.LUA should be found.
oleg-jukovec
force-pushed
the
oleg-jukovec/luarocks-3.10.0-rebase
branch
from
4e8827d
to
917c10d
Compare
|
It looks like there's too much work to do here. Let's just rebase to the latest version, see #24 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.