api: add SSL support #200
Merged
api: add SSL support #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themilchenko
force-pushed
the
themilchenko/gh-35-add-ssl-support
branch
17 times, most recently
from
7f4b1f4
to
c2fe153
Compare
themilchenko
force-pushed
the
themilchenko/gh-35-add-ssl-support
branch
from
c2fe153
to
47576bf
Compare
oleg-jukovec
reviewed
Nov 8, 2024
themilchenko
force-pushed
the
themilchenko/gh-35-add-ssl-support
branch
from
47576bf
to
0d56b8b
Compare
themilchenko
force-pushed
the
themilchenko/gh-35-add-ssl-support
branch
2 times, most recently
from
bcac6a5
to
2291731
Compare
themilchenko
force-pushed
the
themilchenko/gh-35-add-ssl-support
branch
from
2291731
to
4163eb2
Compare
themilchenko
force-pushed
the
themilchenko/gh-35-add-ssl-support
branch
from
4163eb2
to
c9d569b
Compare
http/server.lua
Outdated
Comment on lines
1300
to
1302
| if not sslsocket_supported then | ||
| error("ssl socket is not supported") | ||
| end |
There was a problem hiding this comment.
Please, add the check into validate_ssl_opts too or move it since it is something about validation.
There was a problem hiding this comment.
Moved to validate section.
themilchenko
force-pushed
the
themilchenko/gh-35-add-ssl-support
branch
from
c9d569b
to
64dce9b
Compare
oleg-jukovec
approved these changes
Nov 11, 2024
themilchenko
force-pushed
the
themilchenko/gh-35-add-ssl-support
branch
from
64dce9b
to
2923118
Compare
DerekBum
reviewed
Nov 11, 2024
It wasn't SSL support. After the patch it was added several options to configure SSL, use one of them to enable it: * `ssl_cert_file` is a path to the SSL cert file; * `ssl_key_file` is a path to the SSL key file; * `ssl_ca_file` is a path to the SSL CA file; * `ssl_ciphers` is a colon-separated list of SSL ciphers; * `ssl_password` is a password for decrypting SSL private key; * `ssl_password_file` is a SSL file with key for decrypting SSL private key. Closes #35
There was errors with SSL options for several versions of Tarantool. After the patch building of Tarantool was changed on dynamic one in CI.
themilchenko
force-pushed
the
themilchenko/gh-35-add-ssl-support
branch
from
2923118
to
221e9f0
Compare
DerekBum
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't SSL support. After the patch it was added there are several options to configure SSL:
ssl_cert_fileis a path to the SSL cert file;ssl_key_fileis a path to the SSL key file;ssl_ca_fileis a path to the SSL CA file;ssl_ciphersis a colon-separated list of SSL ciphers;ssl_passwordis a password for decrypting SSL private key;ssl_password_fileis a SSL file with key for decrypting SSL private key.Closes #35