EVM Staking - Add wallet connect and show connected network #1818

devpavan04 · 2023-11-07T20:56:51Z

Summary of changes

Adds wallet connect button.
Adds connected chain info.
Return token unit when balance is zero in validator tables.
Updates connect wallet mobile button to show message for bridge dapp and tangle dapp accordingly.

Proposed area of change

Reference issue to close (if applicable)

Closes [TASK] Implement wallet and network connection #1764

Screen Recording

CleanShot.2023-11-07.at.12.49.11.mp4

…` library

netlify · 2023-11-07T20:56:56Z

✅ Deploy Preview for hubble-stats ready!

Name	Link
🔨 Latest commit	`5f4ec2e`
🔍 Latest deploy log	https://app.netlify.com/sites/hubble-stats/deploys/65518ff34402720008b28546
😎 Deploy Preview	https://deploy-preview-1818--hubble-stats.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-11-07T20:56:56Z

✅ Deploy Preview for tangle-dapp ready!

Name	Link
🔨 Latest commit	`5f4ec2e`
🔍 Latest deploy log	https://app.netlify.com/sites/tangle-dapp/deploys/65518ff334909600080db8b4
😎 Deploy Preview	https://deploy-preview-1818--tangle-dapp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

drewstone · 2023-11-07T21:04:31Z

Awesome work @devpavan04 ! Designs look great @monaiuu

drewstone

LG, a lot changed and small things removed/added. Can you explain rationale?

apps/tangle-dapp/components/WalletDropdown/WalletDropdown.tsx

libs/api-provider-environment/src/store/index.tsx

libs/api-provider-environment/src/webb-context/webb-context.ts

libs/note-manager/src/note-manager.ts

drewstone · 2023-11-07T21:10:54Z

libs/note-manager/src/note-manager.ts

@@ -450,11 +453,6 @@ export class NoteManager {

  /**
   * Generate a note
-   * @param sourceTypedChainId The source typed chain id


Why remove this?

Hey, @devpavan04, could you please assist me in reverting this documentation? I might have accidentally removed it. Please note that I removed the tokenDecimals argument.

drewstone · 2023-11-07T21:12:16Z

CI is also failing @devpavan04

devpavan04 · 2023-11-07T21:41:28Z

@AtelyPham Could you provide more context regarding the changes made to resolve the build error encountered when importing api-provider-environment into tangle next app?

devpavan04 · 2023-11-07T21:48:16Z

@drewstone Sorry for the oversight regarding the use of use client. I made this change in my initial commit to prevent errors related to nextjs, but it is not necessary. I'm looking into CI errors.

github-actions · 2023-11-10T09:42:14Z

✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name	Link
🔨 Latest commit	819181209d27d4a6d3e74be01831580ea38cad69
🔍 Latest deploy log	https://app.netlify.com/sites/development-stats/deploys/654dfaf1420f895d522b6810
😎 Deploy Preview	https://654dfaf1420f895d522b6810--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2023-11-10T09:49:45Z

✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name	Link
🔨 Latest commit	b3e4026c7fa03df2a945df894817b5222407daca
🔍 Latest deploy log	https://app.netlify.com/sites/development-stats/deploys/654dfcb662fc395d640e8a0d
😎 Deploy Preview	https://654dfcb662fc395d640e8a0d--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2023-11-10T09:52:08Z

✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @devpavan04

Name	Link
🔨 Latest commit	b3e4026c7fa03df2a945df894817b5222407daca
🔍 Latest deploy log	https://app.netlify.com/sites/development-hubble-bridge/deploys/654dfd42c49a675b52e10bf6
😎 Deploy Preview	https://654dfd42c49a675b52e10bf6--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2023-11-10T11:12:52Z

✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name	Link
🔨 Latest commit	e6943c2b0030db50dadd0756fb1a71cf6ca32337
🔍 Latest deploy log	https://app.netlify.com/sites/development-stats/deploys/654e10300c946c6a6248f9a9
😎 Deploy Preview	https://654e10300c946c6a6248f9a9--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2023-11-10T11:12:53Z

✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @devpavan04

Name	Link
🔨 Latest commit	e6943c2b0030db50dadd0756fb1a71cf6ca32337
🔍 Latest deploy log	https://app.netlify.com/sites/development-hubble-bridge/deploys/654e10314cd5d06b464d9650
😎 Deploy Preview	https://654e10314cd5d06b464d9650--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

AtelyPham · 2023-11-10T11:28:51Z

apps/bridge-dapp/src/containers/TransferConfirmContainer/TransferConfirmContainer.tsx

      () => calculateTypedChainId(activeChain!.chainType, activeChain!.id),
-      []
+      [activeChain]


Pass the activeChain as the prop here to prevent non-null assertion here.

AtelyPham · 2023-11-10T11:30:09Z

apps/stats-dapp/src/provider/hooks/mappers/index.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */


Why do you need to add this? This is not good actually.

AtelyPham · 2023-11-10T11:30:23Z

apps/stats-dapp/src/provider/hooks/mappers/thresholds.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */


AtelyPham · 2023-11-10T11:30:30Z

apps/stats-dapp/src/provider/hooks/useAuthorities.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */


AtelyPham · 2023-11-10T11:31:43Z

apps/tangle-dapp/components/WalletModal/WalletModal.tsx

Deduplicate this please, I think it is the same with the WalletModal on the bridge.

AtelyPham · 2023-11-10T11:34:34Z

libs/webb-ui-components/src/components/ConnectWalletMobileButton/types.ts

 export interface ConnectWalletMobileButtonProps
  extends IWebbComponentBase,
    Pick<
      ButtonProps,
      'variant' | 'isFullWidth' | 'leftIcon' | 'rightIcon' | 'size' | 'variant'
-    > {}
+    >,
+    MobileButtonProps {}


Why don't we just add the new properties inside the interface curly brackets {}? 🤔 Or why do you want to add the MobileButtonProps type here?

AtelyPham

Left some comments.

github-actions · 2023-11-12T04:33:52Z

✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name	Link
🔨 Latest commit	57e82516928c88008415098ce34c91c377b34cb7
🔍 Latest deploy log	https://app.netlify.com/sites/development-stats/deploys/655055aa4389ab3a6f0f57c7
😎 Deploy Preview	https://655055aa4389ab3a6f0f57c7--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2023-11-12T04:35:41Z

✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @devpavan04

Name	Link
🔨 Latest commit	57e82516928c88008415098ce34c91c377b34cb7
🔍 Latest deploy log	https://app.netlify.com/sites/development-hubble-bridge/deploys/655056156f8699394957cc24
😎 Deploy Preview	https://655056156f8699394957cc24--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2023-11-13T03:01:44Z

✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @AtelyPham

Name	Link
🔨 Latest commit	5f4ec2e2caa3dec77e7aaeeb89d8b058cdff3aa8
🔍 Latest deploy log	https://app.netlify.com/sites/development-stats/deploys/6551919352dd8a798e8067e3
😎 Deploy Preview	https://6551919352dd8a798e8067e3--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2023-11-13T03:01:49Z

✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name	Link
🔨 Latest commit	5f4ec2e2caa3dec77e7aaeeb89d8b058cdff3aa8
🔍 Latest deploy log	https://app.netlify.com/sites/development-hubble-bridge/deploys/65519199154d807682c5e160
😎 Deploy Preview	https://65519199154d807682c5e160--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

devpavan04 and others added 12 commits October 31, 2023 23:22

chore: wrap tangle-dapp with webb provider

482ce71

fix: build issue when importing `@webb-tools/api-provider-environment…

3fd8b07

…` library

ci: bump wagmi and viem to latest version

4f2981a

chore: extract all providers into separate file on tange-dapp

07b028c

fix: local storage is not defined errors

2f890ed

chore: ignore the critical dependency warning from @webb-tools/utils

16f5c0a

chore: install the @polkadot/util to fix the multiple version issue

c29a36b

chore: revert local dependencies

4a99fe0

ci: bump webb.js to fix the next.js build errors

0dad4b3

chore: adds connect wallet functionality

56dede4

chore: show connected network

b1127e1

chore: update validator format balance

0eb7c74

devpavan04 requested review from AtelyPham and vutuanlinh2k2 as code owners November 7, 2023 20:56

Merge branch 'develop' into PS/tangle-dapp-wallet-connection

12fc9db

devpavan04 self-assigned this Nov 7, 2023

devpavan04 added needs review 👓 Pull request needs a review tangle-dapp Tangle Staking dApp labels Nov 7, 2023

drewstone requested changes Nov 7, 2023

View reviewed changes

devpavan04 added 2 commits November 7, 2023 13:26

commit

bac35c2

chore: remove use client from store in api-provider-env

f436939

devpavan04 added 2 commits November 7, 2023 14:01

chore: remove unused variable

557eae6

fix: ci errors

28c7851

AtelyPham self-assigned this Nov 8, 2023

fix: @nx/enforce-module-boundaries error in useConnectWallet

e6943c2

devpavan04 requested a review from AtelyPham November 10, 2023 11:14

AtelyPham reviewed Nov 10, 2023

View reviewed changes

devpavan04 marked this pull request as draft November 10, 2023 11:32

AtelyPham reviewed Nov 10, 2023

View reviewed changes

AtelyPham requested changes Nov 10, 2023

View reviewed changes

devpavan04 added 4 commits November 11, 2023 19:37

chore: move walletModal to ui-components, update prop types

55bce37

fix: forbidden non-null errors in stats-dapp

dacfc46

chore: code format

3f67f51

fix: unused prop error

57e8251

devpavan04 marked this pull request as ready for review November 12, 2023 04:23

devpavan04 requested a review from AtelyPham November 12, 2023 04:37

fix: same library should use relative import

5f4ec2e

AtelyPham approved these changes Nov 13, 2023

View reviewed changes

vutuanlinh2k2 approved these changes Nov 13, 2023

View reviewed changes

AtelyPham merged commit e9d0ef4 into develop Nov 13, 2023
15 of 17 checks passed

AtelyPham deleted the PS/tangle-dapp-wallet-connection branch November 13, 2023 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EVM Staking - Add wallet connect and show connected network #1818

EVM Staking - Add wallet connect and show connected network #1818

devpavan04 commented Nov 7, 2023

netlify bot commented Nov 7, 2023 •

edited

Loading

netlify bot commented Nov 7, 2023 •

edited

Loading

drewstone commented Nov 7, 2023

drewstone left a comment

drewstone Nov 7, 2023

AtelyPham Nov 8, 2023

drewstone commented Nov 7, 2023

devpavan04 commented Nov 7, 2023

devpavan04 commented Nov 7, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

AtelyPham Nov 10, 2023

AtelyPham Nov 10, 2023

AtelyPham Nov 10, 2023

AtelyPham Nov 10, 2023

AtelyPham Nov 10, 2023

AtelyPham Nov 10, 2023 •

edited

Loading

AtelyPham left a comment

github-actions bot commented Nov 12, 2023

github-actions bot commented Nov 12, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

		@@ -1,3 +1,4 @@
		/* eslint-disable @typescript-eslint/no-non-null-assertion */

EVM Staking - Add wallet connect and show connected network #1818

EVM Staking - Add wallet connect and show connected network #1818

Conversation

devpavan04 commented Nov 7, 2023

Summary of changes

Proposed area of change

Reference issue to close (if applicable)

Screen Recording

netlify bot commented Nov 7, 2023 • edited Loading

✅ Deploy Preview for hubble-stats ready!

netlify bot commented Nov 7, 2023 • edited Loading

✅ Deploy Preview for tangle-dapp ready!

drewstone commented Nov 7, 2023

drewstone left a comment

Choose a reason for hiding this comment

drewstone Nov 7, 2023

Choose a reason for hiding this comment

AtelyPham Nov 8, 2023

Choose a reason for hiding this comment

drewstone commented Nov 7, 2023

devpavan04 commented Nov 7, 2023

devpavan04 commented Nov 7, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

AtelyPham Nov 10, 2023

Choose a reason for hiding this comment

AtelyPham Nov 10, 2023

Choose a reason for hiding this comment

AtelyPham Nov 10, 2023

Choose a reason for hiding this comment

AtelyPham Nov 10, 2023

Choose a reason for hiding this comment

AtelyPham Nov 10, 2023

Choose a reason for hiding this comment

AtelyPham Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

AtelyPham left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 12, 2023

github-actions bot commented Nov 12, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

netlify bot commented Nov 7, 2023 •

edited

Loading

netlify bot commented Nov 7, 2023 •

edited

Loading

AtelyPham Nov 10, 2023 •

edited

Loading