Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Account Dashboard Page #1811

Merged
merged 32 commits into from
Nov 2, 2023

Conversation

AtelyPham
Copy link
Member

@AtelyPham AtelyPham commented Oct 31, 2023

Summary of changes

Provide a detailed description of proposed changes.

  • Initialize the Account Dashboard page
  • Integrate Wallet Connection & Account Creation Flow with Dashboard
  • Fix active item in sidebar doesn't update accurately
  • Transition active source chain selection card to dropdown menu
  • Integrate wallet connection & account creation flow with dashboard
  • Migrate notes tables and management features to dashboard
  • Implement core account control features (Deposit, Transfer, Withdraw)
  • Enable hide account data feature

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/tangle-dapp
  • apps/faucet
  • libs/webb-ui-components

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide a screen recording of proposed change.


https://share.cleanshot.com/VGYF6jX9

@AtelyPham AtelyPham added the bridge Issues specific to the bridge label Oct 31, 2023
Copy link

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 18f19bec75235b43dade641296579391d48df9bc
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/65416d1877d212085f5cc565
😎 Deploy Preview https://65416d1877d212085f5cc565--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 18f19bec75235b43dade641296579391d48df9bc
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/65416d27824b3408c01a6c21
😎 Deploy Preview https://65416d27824b3408c01a6c21--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

Deploy Preview for webb faucet is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 18f19bec75235b43dade641296579391d48df9bc
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/65416ea1617b0c095680f70f
😎 Deploy Preview https://65416ea1617b0c095680f70f--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@monaiuu
Copy link
Contributor

monaiuu commented Oct 31, 2023

@AtelyPham Side note, rather than implementing a disabled cursor when hovering over account on the side nav, let's prompt user to connect wallet and create note account instead.

@AtelyPham
Copy link
Member Author

@AtelyPham Side note, rather than implementing a disabled cursor when hovering over account on the side nav, let's prompt user to connect wallet and create note account instead.

In my opinion, prompting users with a wallet selection modal or a note account creation modal when they click on the Account tab may seem counter-intuitive. It alters the expected function of the Account tab. Rather than displaying these modals, we could present clear instructions on how to access the feature. For instance, we could say, "To access this feature, you must connect a wallet and create a note account."

@monaiuu
Copy link
Contributor

monaiuu commented Nov 1, 2023

@AtelyPham Side note, rather than implementing a disabled cursor when hovering over account on the side nav, let's prompt user to connect wallet and create note account instead.

In my opinion, prompting users with a wallet selection modal or a note account creation modal when they click on the Account tab may seem counter-intuitive. It alters the expected function of the Account tab. Rather than displaying these modals, we could present clear instructions on how to access the feature. For instance, we could say, "To access this feature, you must connect a wallet and create a note account."

Prompting users to connect their wallet when they access the 'Account' tab inherently indicates the necessity of a wallet connection and account creation to access the account feature, consistent with login experience where credentials are required to access account. The 'create note account' modal also serves as an instruction, if an account hasn't been created yet. Using a disabled cursor gives the impression that the application is malfunctioning.

I think we should prioritize "show, don't tell" approach by guiding the user through direct user interactions rather than relying on more written instructions to make the experience more straightforward.

Copy link

github-actions bot commented Nov 2, 2023

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit 4d34cdf1e2d325d3f33aa8e92a3bab6f086be15c
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/654391f3c52411008ec847aa
😎 Deploy Preview https://654391f3c52411008ec847aa--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

github-actions bot commented Nov 2, 2023

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit 4d34cdf1e2d325d3f33aa8e92a3bab6f086be15c
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/65439278cd21c3007606803b
😎 Deploy Preview https://65439278cd21c3007606803b--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

github-actions bot commented Nov 2, 2023

Deploy Preview for webb faucet is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit 4d34cdf1e2d325d3f33aa8e92a3bab6f086be15c
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/65439377f9f0dc043a9bbfa7
😎 Deploy Preview https://65439377f9f0dc043a9bbfa7--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

github-actions bot commented Nov 2, 2023

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit bcb11b73196fb1fa4311678197b3aa99c3d98687
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/6543f326daa3b34ca142681e
😎 Deploy Preview https://6543f326daa3b34ca142681e--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

github-actions bot commented Nov 2, 2023

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit bcb11b73196fb1fa4311678197b3aa99c3d98687
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/6543f3a0d052e248b5dcd1e5
😎 Deploy Preview https://6543f3a0d052e248b5dcd1e5--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

github-actions bot commented Nov 2, 2023

Deploy Preview for webb faucet is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit bcb11b73196fb1fa4311678197b3aa99c3d98687
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/6543f3b18fe7d045ae38f5f1
😎 Deploy Preview https://6543f3b18fe7d045ae38f5f1--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge Issues specific to the bridge
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

3 participants