Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect threshold values in key detail page #1743

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

devpavan04
Copy link
Member

Summary of changes

  • Fixes incorrect threshold values in key detail page.

Proposed area of change

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Screen Recording

CleanShot.2023-10-05.at.10.11.09.mp4

@devpavan04 devpavan04 added needs review 👓 Pull request needs a review dkg-stats-dapp labels Oct 5, 2023
@devpavan04 devpavan04 self-assigned this Oct 5, 2023
@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for hubble-stats ready!

Name Link
🔨 Latest commit fadde0d
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/651eef76442f7a0008f8dd60
😎 Deploy Preview https://deploy-preview-1743--hubble-stats.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name Link
🔨 Latest commit fadde0d0b5a68ab4d8457733980b5fa1bf91be50
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/651ef1abc9526d03050df9a1
😎 Deploy Preview https://651ef1abc9526d03050df9a1--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@AtelyPham AtelyPham merged commit 7d7b44c into develop Oct 5, 2023
12 checks passed
@AtelyPham AtelyPham deleted the PS/fix-stats-threshold-bug branch October 5, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dkg-stats-dapp needs review 👓 Pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Stats Dapp - Mismatch between keygen theshold/signature threshold
2 participants