-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more favicons for different browser sizes #1717
Conversation
✅ Deploy Preview for hubble-stats ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @drewstone
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya I'm aware this didn't change it, we'd have to either get a bigger favicon or just not worry about this. CC @monaiuu maybe 16x16 isn't enough and we need 32x32, can you provide? |
✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @drewstone
To edit notification comments on pull requests, go to your Netlify site settings. |
It is because the margins are inconsistent using different images, device specification and favicon sizes should not matter. The correct favicon file can be accessed here: https://www.notion.so/hicommonwealth/Tangle-Logo-029bec068f1a4690a7defc92125be03d?pvs=4 We should remove all old favicon files for Tangle, and opt for the above image in Notion instead. |
Summary of changes
Provide a detailed description of proposed changes.
Proposed area of change
Put an
x
in the boxes that apply.apps/bridge-dapp
apps/hubble-stats
apps/stats-dapp
apps/webbsite
apps/faucet
apps/tangle-website
libs/webb-ui-components
Reference issue to close (if applicable)