Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show chain name in proposal detail #1689

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Show chain name in proposal detail #1689

merged 2 commits into from
Sep 26, 2023

Conversation

devpavan04
Copy link
Member

Summary of changes

  • Show chain name in proposal detail page.

Proposed area of change

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Screen Recording

CleanShot.2023-09-26.at.01.34.14.mp4

@devpavan04 devpavan04 added needs review 👓 Pull request needs a review dkg-stats-dapp labels Sep 26, 2023
@devpavan04 devpavan04 self-assigned this Sep 26, 2023
@netlify
Copy link

netlify bot commented Sep 26, 2023 •
edited
Loading

✅ Deploy Preview for hubble-stats ready!

Name Link
🔨 Latest commit 753fa94
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/65129c0185fb1200082aaf73
😎 Deploy Preview https://deploy-preview-1689--hubble-stats.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devpavan04 devpavan04 marked this pull request as draft September 26, 2023 08:42
drewstone
drewstone approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devpavan04 devpavan04 added wip 🚧 Work in-progress and removed needs review 👓 Pull request needs a review labels Sep 26, 2023
@github-actions
Copy link

✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name Link
🔨 Latest commit f75c1a20e6160ecefc55c8d533f5b678d0d36d2a
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/65129acb5f4fb530bad78c6f
😎 Deploy Preview https://65129acb5f4fb530bad78c6f--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@devpavan04 devpavan04 marked this pull request as ready for review September 26, 2023 08:53
@devpavan04 devpavan04 added needs review 👓 Pull request needs a review and removed wip 🚧 Work in-progress labels Sep 26, 2023
@github-actions
Copy link

✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name Link
🔨 Latest commit 753fa94127d592d2912bf9cfa01e0e43aa8fddbb
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/65129e72789a85008f3965d6
😎 Deploy Preview https://65129e72789a85008f3965d6--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@drewstone drewstone merged commit cb3710c into develop Sep 26, 2023
13 checks passed
@drewstone drewstone deleted the PS/proposal-detail-chain-name branch September 26, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

@AtelyPham AtelyPham Awaiting requested review from AtelyPham AtelyPham is a code owner

@vutuanlinh2k2 vutuanlinh2k2 Awaiting requested review from vutuanlinh2k2

Assignees

@devpavan04 devpavan04

Labels
dkg-stats-dapp needs review 👓 Pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Show chain name in proposal detail page
2 participants
@devpavan04 @drewstone