Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubble Bridge V2 UI #1578

Merged
merged 139 commits into from
Sep 8, 2023
Merged

Hubble Bridge V2 UI #1578

merged 139 commits into from
Sep 8, 2023

Conversation

AtelyPham
Copy link
Member

@AtelyPham AtelyPham commented Sep 1, 2023

Summary of changes

  • Introduce new UI for Hubble Bridge V2 which includes new features
    • Route based components and states
    • Custom relayer
    • Interaction with the bridge while no wallet connected.
    • ...

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Screen Recording

If possible provide a screen recording of proposed change.


Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

AtelyPham and others added 30 commits July 26, 2023 13:15
Co-authored-by: Pavan Soratur <[email protected]>
Co-authored-by: drewstone <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AtelyPham <[email protected]>
Co-authored-by: Trung-Tin Pham <[email protected]>
@tangle-network tangle-network deleted a comment from github-actions bot Sep 7, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Sep 7, 2023
@AtelyPham AtelyPham added needs review 👓 Pull request needs a review and removed do not merge 🛑 wip 🚧 Work in-progress labels Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit a4d0f73326fec03786ebbcd06dbd8c0d1e695f00
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/64f98ee15f835a52fc3f639a
😎 Deploy Preview https://64f98ee15f835a52fc3f639a--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit a4d0f73326fec03786ebbcd06dbd8c0d1e695f00
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/64f98ef0981eec51c28a1710
😎 Deploy Preview https://64f98ef0981eec51c28a1710--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@monaiuu monaiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transaction Input Card Updates:

Screenshot 2023-09-08 at 11 01 17 AM
  • Reposition 'Fixed' and 'Custom' amount labels.

  • Adjust padding to 6px for top and bottom, improving bridge card height.

  • Implement missing hover state in dark mode with fill color set to 'monochrome/170'.

  • In light mode, update default fill color to 'monochrome/20' and hover state fill color to 'E2E5EB' at 30% opacity for better contrast.

  • Standardize stepper amount display to show 2 decimal places.

  • Incorporate tooltips for 'Fixed' and 'Custom' amounts as shown below.

Screenshot 2023-09-08 at 11 02 24 AM
  • If user opts for no relayer, update copy to No relayer for clarity as shown below.
Screenshot 2023-09-08 at 1 05 02 PM

Figma Link

@monaiuu
Copy link
Contributor

monaiuu commented Sep 8, 2023

Overall Updates Checklist:

Functions:

  • Remove the 'fixed amount' option from the transfer flow.
Screenshot 2023-09-08 at 1 06 10 PM

UI & Theme:

  • Add drop shadow to bridge card for improved contrast from background:
    • Light mode: #000 at 10% opacity, Y=8, Blur=50
    • Dark mode: #000 at 20% opacity, Y=8, Blur=50
Screenshot 2023-09-08 at 12 16 32 PM Screenshot 2023-09-08 at 12 15 46 PM
  • Improve contrast for light theme toggle switch in checked state:
    • Update handle color from Light/Blue/10 to Light/Blue/40.
Screenshot 2023-09-08 at 1 08 52 PM
  • Ensure the footer is anchored to the bottom on larger screens.
    Screenshot 2023-09-05 at 2 31 08 PM

Navigation & Labels:

  • Enhance breadcrumb usage for consistency with Hubble Stats:
    • First breadcrumb: 'Hubble Bridge'
    • Second breadcrumb: Specific tab (e.g., deposit, transfer, withdrawal)
    • Third breadcrumb: Selection card title
Screenshot 2023-09-08 at 1 14 32 PM
  • Standardize chain list naming in chain selection (e.g., Sepolia & Goerli should include 'Ethereum').
  • Use lowercase for 'webbAlpha' in token selection.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit e2ffe21f114c9e6786cec8dae86dd0f039935e2f
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/64fb936f00d9d5635b8e1217
😎 Deploy Preview https://64fb936f00d9d5635b8e1217--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit e2ffe21f114c9e6786cec8dae86dd0f039935e2f
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/64fb941f2ec0d9648fcd0a79
😎 Deploy Preview https://64fb941f2ec0d9648fcd0a79--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@AtelyPham AtelyPham merged commit cc36d0c into develop Sep 8, 2023
12 checks passed
@AtelyPham AtelyPham deleted the trung-tin/new-hubble-bridge-v2-ui branch September 8, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment