Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: progress bar reset & remove proposals chart #1397

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Fix: progress bar reset & remove proposals chart #1397

merged 4 commits into from
Jul 13, 2023

Conversation

devpavan04
Copy link
Member

Summary of changes

  • Both the progress bar on keys page and authorities page starts from start.

Proposed area of change

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Screen Recording

CleanShot.2023-07-06.at.06.06.08.mp4

@devpavan04 devpavan04 added needs review 👓 Pull request needs a review statistics labels Jul 6, 2023
@devpavan04 devpavan04 self-assigned this Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

✅ Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name Link
🔨 Latest commit 6a31c5090104de7d63a414344251ab8c5a0a5b02
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/64a6bdec0991212a29dfa3c6
😎 Deploy Preview https://64a6bdec0991212a29dfa3c6--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@devpavan04 devpavan04 changed the title Fix: progress bar reset Fix: progress bar reset & remove proposals chart Jul 6, 2023
@devpavan04 devpavan04 added wip 🚧 Work in-progress and removed needs review 👓 Pull request needs a review labels Jul 6, 2023
@devpavan04 devpavan04 marked this pull request as draft July 6, 2023 13:33
@drewstone
Copy link
Contributor

Can we animate it @devpavan04 so it grows from 0 to its progress?

@devpavan04
Copy link
Member Author

Can we animate it @devpavan04 so it grows from 0 to its progress?

@drewstone Already working on it 👍🏼

@devpavan04 devpavan04 added needs review 👓 Pull request needs a review and removed wip 🚧 Work in-progress labels Jul 11, 2023
@devpavan04 devpavan04 marked this pull request as ready for review July 11, 2023 12:04
@devpavan04
Copy link
Member Author

Can we animate it @devpavan04 so it grows from 0 to its progress?

After spending quite some time in debugging this issue @AtelyPham and I have decided to pick this up in the next sprint.

Issue - #1422

@devpavan04 devpavan04 merged commit b0716f1 into develop Jul 13, 2023
6 checks passed
@devpavan04 devpavan04 deleted the PS/progress-bar-reset-fix branch July 13, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simlarsen simlarsen simlarsen approved these changes

@AtelyPham AtelyPham Awaiting requested review from AtelyPham AtelyPham is a code owner

@vutuanlinh2k2 vutuanlinh2k2 Awaiting requested review from vutuanlinh2k2

Assignees

@devpavan04 devpavan04

Labels
needs review 👓 Pull request needs a review statistics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devpavan04 @drewstone @simlarsen