-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#18 Embed images #21
base: main
Are you sure you want to change the base?
#18 Embed images #21
Conversation
Ready for review! The reviewer will once again be next-week-Kevin, who will also create tickets for the TODOs and link them in the code, and make the 1.2 release. |
Just realized that I'd only tested this by adding images to existing pages. It doesn't work when adding a new document with an image, because the logic that adds attachments runs inside |
Closes #18, #19
The idea is to attach the file to the wiki page. The tricky bit will be to figure out when to update it (what if you update an image but not the document(s) that use it?), but we can worry about that later. Having an initial version of the image is better than the current situation.