Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run tests across zkVM using mocked guest programs #438

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Dec 19, 2024

Run Example:

RUST_LOG=info cargo test --release --features in-memory,risc0,test-mock-guest test_v2_mainnet_prove_risc0 -- --nocapture

Copy link
Contributor

@smtmfft smtmfft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
will you also add sp1 mock? or you think r0 mock is enough for test purpose?

One more thing is update corresponding scope to ci.yml

&[
"risc0-guest",
"risc0-aggregation",
"risc0-guest-mock",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better to use feature to separate build.
please also check if the image id output in compile log is clear or not as we need give that id to client to config the contract.

@keroro520 keroro520 marked this pull request as draft December 25, 2024 08:13
@keroro520
Copy link
Contributor Author

LGTM. will you also add sp1 mock? or you think r0 mock is enough for test purpose?

One more thing is update corresponding scope to ci.yml

Thanks for your review.
While I transfer it to draft status because I come up with another idea, which may make test more simply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants