Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taskdb): remove sqlite task manager #423

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Nov 28, 2024

The SQLite Task Manager isn't used in testing or development, and it's not fit for production due to a lack of easy-to-use and reliable options. Meanwhile, its code is relatively complex, and adapting and testing each interface with it adds to our maintenance costs. (here is an example, when adding Aggregation Cancel API, we need to add SQLite interfaces, however it's useless for us )

So, I suggest we remove it and bring it back if needed later.

@keroro520 keroro520 enabled auto-merge November 28, 2024 12:05
@keroro520 keroro520 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into taikoxyz:main with commit 89f748f Nov 28, 2024
15 checks passed
@keroro520 keroro520 deleted the feat-remove-sqlite branch November 28, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants