Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #531: Fix missing impl for TransactionError #579

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

alecsmrekar
Copy link
Contributor

This PR addressed issue #531.

The original bug report provided a minimum reproducible code, but I think we're able to shrink that even further to:

async fn test_case(user: &mut GooseUser) -> TransactionResult {
    let goose = user
        .get("my/url")
        .await?;
    let _ = goose.response?;
    Ok(())
}

Trying to compile a loadtest with this code should give the following error:

the trait `From<reqwest::error::Error>` is not implemented for `Box<TransactionError>`

With this PR, it should compile cleanly.

Copy link
Member

@jeremyandrews jeremyandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Closes #531

@jeremyandrews jeremyandrews merged commit cafbadf into main Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants