-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand childElement with its content #3
Comments
The dimension is intentionally made fixed for every transition to be supported out of the box. Most of the transitions rely on a fixed bounding box. Contents outside of the box is In the case of dynamic height for a seamless footer on the bottom, some transitions will not fit since they require fixed height. Yet there could be some improvement given to relax the restriction, by providing an option to customize the default style, it would be essentially equivalent to tuning the source. |
I already figured that out. I tried balancing positions , using float , using flex but it didn't work. Do you have any idea how to modify this to work? |
OK try this:
This way when component is longer js will expand app height. |
I see it as setting the wrapper height dynamically based on the fetched height of the content. |
Exactly. Position absolute is taken out of normal flow of website. So if it has to stay this was the only way to fix that. |
Some CSS properties can indeed be ignored for limited animations. Tune them as you need to. I believe most of the time only a selection of animations are actually in use. I am considering to give an option which when present overrides the default style of the wrapper for flexibility. Thanks for this feedback! |
I am using this transitions to switch pages with text. Text will be generated so it will have various height. Overflow is set to hidden so if my text page is longer it just disappears. I'd like to allow expanding to match content height. I must admit I modified this react-transitions slightly but my mods are not causing this issue.
The biggest problem is position absolute. Element with such position acts differently in webpage flow. Also disabling it causes animations to act weird: mid transition two pages with text are visible which looks bad.
tParent and tChild are custom names for classes generated by react-transitions
My current html part:
Relevant css:
I need that because I want to add footer below this transition.
Here is the link to my latest efforts on setting it up.
The text was updated successfully, but these errors were encountered: