Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration with react-router #6

Open
MikeDabrowski opened this issue Jun 17, 2017 · 2 comments
Open

integration with react-router #6

MikeDabrowski opened this issue Jun 17, 2017 · 2 comments

Comments

@MikeDabrowski
Copy link

Since I love your work here I'd like to use it everywhere. Is there a way to integrate these transitions with react-router?

Simply merging these two together does not actualy work because route vanishes and transition can't kick in.

@szchenghuang
Copy link
Owner

When routes changes, components associated with the previous route unmount and those with the coming route mount in general. From this angle it should be possible, since ReactTransitionGroup handles component leaving/entering the DOM.

On the other hand, however, page size usually changes with routes . Since this package has its limitation with respect to dynamic component size as stated in #3, integration with router comes with some limitation as well.

It would be nice if there is a demo on this, while my thought above could be vague. Hope I can find time to make one. Thanks for your feedback though.

@MikeDabrowski
Copy link
Author

MikeDabrowski commented Jun 20, 2017

At this point I can't even make this work with router. As for resize problems I'd probably go and handle them with js.

Most problems would be solved if you could rewrite whole component to work without position absolute. Though that's probably not easy to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants