initial commit #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
szaimen
commented
Jan 17, 2025
•
szaimen
commented
- fix comments in the code and on github
- test
- add docker hub credentials to the repo
- create PR in the aio repo that adds this
- more?
Signed-off-by: Simon L. <[email protected]>
szaimen
commented
Jan 17, 2025
| adduser \ | ||
| ; \ | ||
| rm -rf /var/lib/apt/lists/*; \ | ||
| # rm /etc/cont-init.d/10-init-users.sh; \ # This script tries to delete the /etc/shadow and /etc/group files |
There was a problem hiding this comment.
this needs to be handled...
szaimen
commented
Jan 17, 2025
Comment on lines
+3
to
+4
| groupadd -g 33 www-data | ||
| adduser --no-create-home --quiet --uid 33 --gid 33 --disabled-login --force-badname --gecos www-data www-data |
There was a problem hiding this comment.
maybe also copy the /etc/group and /etc/shadow files to a volume after the initial creation and then always copy it back and also before stopping save it in a volume... Same could be done for other important files
szaimen
commented
Jan 17, 2025
Comment on lines
+40
to
+43
| VOLUME /etc/samba | ||
| # VOLUME /etc/group # is a file | ||
| # /etc/shadow auch reinmounten, beides read-write. | ||
| # Crontabs are need to be stored as well? |
27 tasks
szaimen
commented
Jan 17, 2025
|
|
||
| COPY --chmod=775 startapp.sh /startapp.sh | ||
| ADD https://raw.githubusercontent.com/nextcloud/vm/refs/heads/main/static/fetch_lib.sh /var/scripts/fetch_lib.sh | ||
| ADD https://raw.githubusercontent.com/nextcloud/vm/main/lib.sh /var/scripts/lib.sh | ||
| ADD https://raw.githubusercontent.com/nextcloud/vm/refs/heads/main/not-supported/smbserver.sh /smbserver.sh |
There was a problem hiding this comment.
also need to modify the script to allow normal directories, not only mountpoints: https://github.com/nextcloud/vm/blob/b98a75bd503427366a566db699c09474196c7813/not-supported/smbserver.sh#L56-L60
There was a problem hiding this comment.
Also systemctl is not supported...
szaimen
commented
Jan 17, 2025
| trap clean_up_backup SIGINT SIGTERM | ||
|
|
||
| # Start xterm | ||
| xhost +si:localuser:root | ||
| exec xterm |
There was a problem hiding this comment.
It should also start the smb services in the background...
szaimen
commented
Jan 19, 2025
| @@ -13,28 +16,29 @@ ENV USER_ID=0 \ | |||
| WEB_AUDIO=1 \ | |||
| WEB_AUTHENTICATION=1 \ | |||
| SECURE_CONNECTION=1 \ | |||
| HOME=/root | |||
| WEB_LISTENING_PORT=5600 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.