Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that BuildSources= inputs are directories #3184

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Check that BuildSources= inputs are directories #3184

merged 1 commit into from
Nov 14, 2024

Conversation

DaanDeMeyer
Copy link
Contributor

Fixes #3181

behrmann
behrmann approved these changes Nov 12, 2024
View reviewed changes
mkosi/config.py Outdated Show resolved Hide resolved
@septatrix
Copy link
Contributor

I am fine with making this setting require directories but why is this not a problem with e.g. SkeletonTrees=? It is able to handle file sources without a problem

@DaanDeMeyer
Copy link
Contributor Author

I am fine with making this setting require directories but why is this not a problem with e.g. SkeletonTrees=? It is able to handle file sources without a problem

Trees are copied, build sources are mounted, potentially ephemerally, and potentially with virtiofsd which only supports directories.

@DaanDeMeyer DaanDeMeyer merged commit 8a29e9e into systemd:main Nov 14, 2024
31 of 36 checks passed
@DaanDeMeyer DaanDeMeyer deleted the directory branch November 14, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behrmann behrmann behrmann approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sandbox fails when using mount shorthand for mounting file
3 participants
@DaanDeMeyer @septatrix @behrmann