Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shield): allow to specify the security context for the Cluster Shield in the shield chart #2130

Merged
merged 2 commits into from
Jan 31, 2025
Merged

feat(shield): allow to specify the security context for the Cluster Shield in the shield chart #2130

merged 2 commits into from
Jan 31, 2025

Conversation

mavimo
Copy link
Contributor

@mavimo mavimo commented Jan 24, 2025

What this PR does / why we need it:

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@mavimo mavimo requested a review from a team as a code owner January 24, 2025 11:08
@mavimo mavimo force-pushed the allow-to-specify-security-context-for-cluster-in-shield branch 3 times, most recently from 2cdd86d to 85a3511 Compare January 27, 2025 09:21
iurly
iurly approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@iurly iurly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mavimo mavimo force-pushed the allow-to-specify-security-context-for-cluster-in-shield branch from 85a3511 to f24023f Compare January 31, 2025 11:37
@mavimo mavimo enabled auto-merge (squash) January 31, 2025 11:38
@mavimo mavimo merged commit 3d75369 into main Jan 31, 2025
4 checks passed
@mavimo mavimo deleted the allow-to-specify-security-context-for-cluster-in-shield branch January 31, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iurly iurly iurly approved these changes

@AlbertoBarba AlbertoBarba AlbertoBarba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mavimo @AlbertoBarba @iurly