feat(KSPM admission controller): SSPROD-35354 - Make Dry Run mode configurable to a user in Chart Values. #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lior-alafi-work
requested changes
Jan 8, 2024
There was a problem hiding this comment.
@dimar-apolicy can you also add the default value to be true?
i.e
value: {{ .Values.webhook.dryRun | default "true" | quote }}
lior-alafi-work
approved these changes
Jan 9, 2024
airadier
approved these changes
Jan 11, 2024
| @@ -54,8 +54,12 @@ spec: | |||
| image: {{ include "admissionController.kspm.image" . }} | |||
| imagePullPolicy: {{ .Values.webhook.v2.image.pullPolicy | default .Values.global.image.pullPolicy }} | |||
| env: | |||
| - name: DEFAULT_TIMEOUT | |||
| - value: {{ .Values.webhook.timeoutSeconds}} | |||
| - name: DENY_ON_ERROR | |||
There was a problem hiding this comment.
Should we configure the failurePolicy accordingly?
EG: heres what happens with the webhook right now https://github.com/sysdiglabs/charts/blob/master/charts/admission-controller/templates/_helpers.tpl#L453
There was a problem hiding this comment.
@AlbertoBarba there is no change in existing logic, just using the value in another container.
AlbertoBarba
approved these changes
Jan 15, 2024
# Conflicts: # charts/sysdig-deploy/Chart.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Proposed changes will allow configuring the
dry-runand thedenyOnErrorsettings of KSPM admission controller.JIRA ticket: Make Dry Run mode configurable to a user in Chart Values
Checklist
Check Contribution guidelines in README.md for more insight.