Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(admission-controller): add ports to service conditionally #1558

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

airadier
Copy link
Collaborator

@airadier airadier commented Jan 4, 2024

What this PR does / why we need it:

The service defines the ports for both old AC and new KSPM AC without checking if the containers are deployed. Adding a conditional so the service port is only defined when the container is deployed too.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@airadier airadier marked this pull request as ready for review January 4, 2024 11:07
@airadier airadier requested a review from a team as a code owner January 4, 2024 11:07
@airadier airadier requested a review from hayk99 January 4, 2024 11:07
@airadier airadier enabled auto-merge (squash) January 4, 2024 12:33
@airadier airadier merged commit 3915ce1 into master Jan 4, 2024
9 checks passed
@airadier airadier deleted the ac-conditional-service-ports branch January 4, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants