feat(hostScanner): Add container scanner feature [SSPROD-32268] #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedericoFeresini
force-pushed
the
ff/chart/public/SSPROD-32268
branch
3 times, most recently
from
fece9e1 to
e954d81
Compare
FedericoFeresini
force-pushed
the
ff/chart/public/SSPROD-32268
branch
from
e954d81 to
3de594b
Compare
charts/node-analyzer/Chart.yaml
Outdated
| @@ -3,7 +3,7 @@ name: node-analyzer | |||
| description: Sysdig Node Analyzer | |||
|
|
|||
| # currently matching Sysdig's appVersion 1.14.34 | |||
| version: 1.18.8 | |||
| version: 1.18.9 | |||
There was a problem hiding this comment.
Suggested change
| version: 1.18.9 | |
| version: 1.19.0 |
charts/node-analyzer/README.md
Outdated
Comment on lines
212
to
214
| | `nodeAnalyzer.hostScanner.scanContainers.enabled` | Set to `true` to scan containers | `false` | | ||
| | `nodeAnalyzer.hostScanner.scanContainers.dockerSocketPath` | Specifies the path to docker socket | ` ` | | ||
| | `nodeAnalyzer.hostScanner.scanContainers.podmanSocketPath` | Specifies the path to podman socket | ` ` | |
There was a problem hiding this comment.
Suggested change
| | `nodeAnalyzer.hostScanner.scanContainers.enabled` | Set to `true` to scan containers | `false` | | |
| | `nodeAnalyzer.hostScanner.scanContainers.dockerSocketPath` | Specifies the path to docker socket | ` ` | | |
| | `nodeAnalyzer.hostScanner.scanContainers.podmanSocketPath` | Specifies the path to podman socket | ` ` | | |
| | `nodeAnalyzer.hostScanner.scanContainers.enabled` | Set to `true` to scan containers | `false` | | |
| | `nodeAnalyzer.hostScanner.scanContainers.dockerSocketPath` | Specifies the path to docker socket | ` ` | | |
| | `nodeAnalyzer.hostScanner.scanContainers.podmanSocketPath` | Specifies the path to podman socket | ` ` | |
Indentation shall be revised.
I'd also change the description for the paths Specifies the optional path to docker socket. By default it will use unix://....
charts/sysdig-deploy/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: sysdig-deploy | |||
| description: A chart with various Sysdig components for Kubernetes | |||
| type: application | |||
| version: 1.31.1 | |||
| version: 1.31.2 | |||
There was a problem hiding this comment.
Suggested change
| version: 1.31.2 | |
| version: 1.32.0 |
We are releasing a new feature, so I'd bump at least the minor ;)
Comment on lines
886
to
891
| - name: SCAN_CONTAINERS_ENABLED | ||
| valueFrom: | ||
| configMapKeyRef: | ||
| name: {{ .Release.Name }}-host-scanner | ||
| key: container_scan_enabled | ||
| optional: true |
There was a problem hiding this comment.
Suggested change
| - name: SCAN_CONTAINERS_ENABLED | |
| valueFrom: | |
| configMapKeyRef: | |
| name: {{ .Release.Name }}-host-scanner | |
| key: container_scan_enabled | |
| optional: true | |
| - name: SCAN_CONTAINERS_ENABLED | |
| value: "true" |
FedericoFeresini
force-pushed
the
ff/chart/public/SSPROD-32268
branch
from
3de594b to
23fcd37
Compare
charts/node-analyzer/README.md
Outdated
Comment on lines
212
to
214
| | `nodeAnalyzer.hostScanner.scanContainers.enabled` | Set to `true` to scan containers | `false` | | ||
| | `nodeAnalyzer.hostScanner.scanContainers.dockerSocketPath` | Specifies the path to docker socket | `unix:///var/run/docker.sock` | | ||
| | `nodeAnalyzer.hostScanner.scanContainers.podmanSocketPath` | Specifies the path to podman socket | `unix:///var/run/podman.sock` | |
There was a problem hiding this comment.
Indentation still seems to be slightly off here.
FedericoFeresini
force-pushed
the
ff/chart/public/SSPROD-32268
branch
from
1a19302 to
ffef47e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.