Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(registry-scanner): add support for cronjob timezone selection #1481

Merged
merged 7 commits into from
Nov 17, 2023
Merged

feat(registry-scanner): add support for cronjob timezone selection #1481

merged 7 commits into from
Nov 17, 2023

Conversation

IgorEulalio
Copy link
Collaborator

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ x ] Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • [ x ] Chart Version bumped for the respective charts
  • [ x ] Variables are documented in the README.md (or README.tpl in some charts)
  • [ x ] Check GithubAction checks (like lint) to avoid merge-check stoppers
  • [ x ] All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@IgorEulalio IgorEulalio requested review from a team as code owners November 16, 2023 18:46
hayk99
hayk99 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@hayk99 hayk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR! 🚀

@hayk99
Copy link
Contributor

hayk99 commented Nov 16, 2023

https://jenkins.internal.sysdig.tools/job/qa/job/QA-secure/job/vm/job/registry-scanner-all-ondemand/5/ tested with QA pipeline, looks good :D

@AlbertoBarba AlbertoBarba enabled auto-merge (squash) November 17, 2023 08:46
@AlbertoBarba AlbertoBarba merged commit b952290 into master Nov 17, 2023
5 checks passed
@AlbertoBarba AlbertoBarba deleted the feature/FR-1392 branch November 17, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayk99 hayk99 hayk99 approved these changes

@AlbertoBarba AlbertoBarba AlbertoBarba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IgorEulalio @hayk99 @AlbertoBarba