Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry-scanner): Add flag to enable mem profile dumps on a PVC #1455

Merged
merged 3 commits into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/registry-scanner/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ description: Sysdig Registry Scanner
type: application
home: https://sysdiglabs.github.io/registry-scanner/
icon: https://478h5m1yrfsa3bbe262u7muv-wpengine.netdna-ssl.com/wp-content/uploads/2019/02/Shovel_600px.png
version: 1.1.16
appVersion: 0.2.54
version: 1.1.17
appVersion: 0.2.56
maintainers:
- name: giuse-sysdig
email: [email protected]
Expand Down
3 changes: 2 additions & 1 deletion charts/registry-scanner/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ The following table lists the configurable parameters of the Sysdig Registry Sca
| scanOnStart.jobName | The name of the job created for the post-install scanner job | <code>"registry-scanner-start-test"</code> |
| scanOnStart.asPostInstallHook | Specify whether to launch the job as a post-install helm hook. <br/>Used for testing purpose. | <code>false</code> |
| extraEnvVars | The additional environment variables to be set. | <code>[]</code> |
| memProfileToPersistentVolumeClaim | Write memory profile dumps to Persistent Volume Claim (provide PVC name) | <code>""</code> |

## On-Prem Deployment

Expand All @@ -126,7 +127,7 @@ Use the following command to deploy:
helm upgrade --install registry-scanner \
--namespace sysdig-agent \
--create-namespace \
--version=1.1.16 \
--version=1.1.17 \
--set config.secureBaseURL=<SYSDIG_SECURE_URL> \
--set config.secureAPIToken=<SYSDIG_SECURE_API_TOKEN> \
--set config.secureSkipTLS=true \
Expand Down
13 changes: 13 additions & 0 deletions charts/registry-scanner/templates/_job.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
- name: report-storage
mountPath: "/output"
{{- end }}
{{- if .Values.memProfileToPersistentVolumeClaim }}
- name: profile-storage
mountPath: "/profiling"
{{- end }}
{{- if .Values.ssl.ca.certs }}
- name: ca-certs
mountPath: "/ca-certs"
Expand Down Expand Up @@ -120,6 +124,10 @@
- name: GROUP_LIMIT
value: "{{ .Values.config.parallelGoRoutines }}"
{{- end }}
{{- if .Values.memProfileToPersistentVolumeClaim }}
- name: PROFILING_ENABLED
value: /profiling
{{- end }}
{{- if .Values.extraEnvVars }}
{{- toYaml .Values.extraEnvVars | nindent 10 }}
{{- end }}
Expand Down Expand Up @@ -154,4 +162,9 @@
persistentVolumeClaim:
claimName: {{ .Values.reportToPersistentVolumeClaim }}
{{- end }}
{{- if .Values.memProfileToPersistentVolumeClaim }}
- name: profile-storage
persistentVolumeClaim:
claimName: {{ .Values.memProfileToPersistentVolumeClaim }}
{{- end }}
{{- end }}
3 changes: 3 additions & 0 deletions charts/registry-scanner/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -224,3 +224,6 @@ scanOnStart:
extraEnvVars: []
# - name: FOO
# value: bar

# Write memory profile dumps to Persistent Volume Claim (provide PVC name)
memProfileToPersistentVolumeClaim: ""
Loading