Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-analyzer): Enable debug flag per single VM component(new engine only) and KSPM #1401

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

dark-vex
Copy link
Collaborator

@dark-vex dark-vex commented Oct 16, 2023

What this PR does / why we need it:

This allow to set debug true or trace per each VM components (only for new engine) instead of setting it for all the components.

I have also included KSPM Analyzer under the nodeAnalyzer.debug flag.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@dark-vex dark-vex requested review from ProvoK and mech-pig October 16, 2023 09:28
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@dark-vex dark-vex changed the title Enable debug flag per single VM component(new engine only) and KSPM feat(node-analyzer): Enable debug flag per single VM component(new engine only) and KSPM Oct 16, 2023
@github-actions github-actions bot dismissed their stale review October 16, 2023 09:36

All good!

@mavimo mavimo force-pushed the ddl-na-debug-flag branch from 8332d09 to 5abdfd1 Compare October 25, 2023 16:17
@dark-vex dark-vex requested a review from a team as a code owner November 2, 2023 09:09
Signed-off-by: Daniele De Lorenzi <[email protected]>
@dark-vex dark-vex merged commit efa8afe into master Nov 2, 2023
@dark-vex dark-vex deleted the ddl-na-debug-flag branch November 2, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants