-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node-analyzer): Enable debug flag per single VM component(new engine only) and KSPM #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$
!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests
dark-vex
changed the title
Enable debug flag per single VM component(new engine only) and KSPM
feat(node-analyzer): Enable debug flag per single VM component(new engine only) and KSPM
Oct 16, 2023
FedericoFeresini
approved these changes
Oct 16, 2023
FedericoFeresini
approved these changes
Oct 16, 2023
…gine only) and KSPM Signed-off-by: Daniele De Lorenzi <[email protected]>
…gine only) and KSPM Signed-off-by: Daniele De Lorenzi <[email protected]>
Signed-off-by: Daniele De Lorenzi <[email protected]>
Signed-off-by: Daniele De Lorenzi <[email protected]>
Signed-off-by: Daniele De Lorenzi <[email protected]>
Signed-off-by: Daniele De Lorenzi <[email protected]>
mavimo
force-pushed
the
ddl-na-debug-flag
branch
from
October 25, 2023 16:17
8332d09
to
5abdfd1
Compare
Signed-off-by: Daniele De Lorenzi <[email protected]>
Signed-off-by: Daniele De Lorenzi <[email protected]>
dark-vex
force-pushed
the
ddl-na-debug-flag
branch
from
November 2, 2023 09:38
2f882c4
to
b265985
Compare
mavimo
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allow to set debug
true
ortrace
per each VM components (only for new engine) instead of setting it for all the components.I have also included KSPM Analyzer under the
nodeAnalyzer.debug
flag.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.