Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kspm-collector): Enable annotations on kspm collector deployment pods #1346

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

narendramannam
Copy link
Contributor

@narendramannam narendramannam commented Sep 7, 2023

What this PR does / why we need it:

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Hi @narendramannam. Thanks for your PR.

After inspecting your changes someone with write access to this repo needs
to approve and run the workflow with the following slash_command.

NOTE: the workflow triggered this way will only report the final status to this PR,
in order to check the logs please go to the Actions tab and look for approve-test-run-command.

  • /approve-test-run sha=<short commit sha to test>: Run helm chart linting and testing workflow

@narendramannam narendramannam marked this pull request as ready for review September 7, 2023 09:53
@narendramannam
Copy link
Contributor Author

This MR is to address FR-1180

@github-actions github-actions bot removed the no-tests Chart templates modified without test changes label Oct 27, 2023
@mavimo mavimo force-pushed the kspmcollector-annotations branch from a72455d to 155804f Compare October 27, 2023 07:51
@mavimo mavimo force-pushed the kspmcollector-annotations branch from 155804f to 82c37cf Compare October 30, 2023 19:06
@mavimo mavimo merged commit 4bf9758 into sysdiglabs:master Oct 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants