Merge pull request #2430 from synonymdev/chore/biome

chore: switch to biome for lint and format

.github/workflows/lint-check.yml

@@ -5,7 +5,7 @@ on:
   pull_request:
 
 jobs:
-  eslint:
+  lint:
     name: Run lint check
     runs-on: ubuntu-latest
 

biome.json

@@ -0,0 +1,35 @@
+{
+	"files": {
+		"ignore": ["src/polyfills/**"]
+	},
+	"linter": {
+		"rules": {
+			"complexity": {
+				"noBannedTypes": "off",
+				"noForEach": "off"
+			},
+			"performance": {
+				"noAccumulatingSpread": "off"
+			},
+			"suspicious": {
+				"noExplicitAny": "off",
+				"noArrayIndexKey": "off"
+			},
+			"style": {
+				"noNonNullAssertion": "off",
+				"noParameterAssign": "off",
+				"useImportType": "off",
+				"useNodejsImportProtocol": "off"
+			}
+		}
+	},
+	"javascript": {
+		"formatter": {
+			"bracketSameLine": true,
+			"quoteStyle": "single"
+		}
+	},
+	"organizeImports": {
+		"enabled": false
+	}
+}

nano-staged.js

@@ -1,4 +1,3 @@
 module.exports = {
-	'src/**/*.{ts,tsx}': ['prettier --write', 'eslint --ext .ts,.tsx'],
-	'*.{yml,md}': ['prettier --write'],
+  "src/**/*.{ts,tsx}": ["biome check"],
 };

package.json

@@ -17,8 +17,10 @@
     "e2e:test:ios-release": "detox test --configuration ios.release",
     "e2e:test:android-debug": "DEV=true detox test --configuration android.debug",
     "e2e:test:android-release": "detox test --configuration android.release",
-    "lint:check": "eslint . --ext .js,.jsx,.ts,.tsx",
-    "lint:fix": "eslint . --fix --ext .js,.jsx,.ts,.tsx",
+    "format:check": "biome format ./src/**/*.{js,jsx,ts,tsx}",
+    "format:fix": "biome format --write ./src/**/*.{js,jsx,ts,tsx}",
+    "lint:check": "biome lint ./src/**/*.{js,jsx,ts,tsx}",
+    "lint:fix": "biome lint --write ./src/**/*.{js,jsx,ts,tsx}",
     "tsc:check": "tsc -p tsconfig.json --noEmit",
     "clean": "yarn clean:rn && yarn clean:ios && yarn clean:android && yarn start --reset-cache",
     "clean:rn": "watchman watch-del-all && npx del-cli node_modules && yarn && npx del-cli /tmp/metro-*",
@@ -129,12 +131,12 @@
     "@babel/plugin-proposal-async-generator-functions": "^7.20.7",
     "@babel/preset-env": "^7.24.4",
     "@babel/runtime": "^7.24.4",
+    "@biomejs/biome": "^1.9.4",
     "@commitlint/cli": "^19.2.2",
     "@commitlint/config-conventional": "^19.2.2",
     "@ptsecurity/commitlint-config": "^2.0.0",
     "@radar/lnrpc": "^0.11.1-beta.1",
     "@react-native/babel-preset": "^0.75.2",
-    "@react-native/eslint-config": "^0.75.2",
     "@react-native/metro-config": "^0.75.2",
     "@react-native/typescript-config": "^0.75.2",
     "@types/b4a": "^1.6.4",
@@ -152,15 +154,12 @@
     "bitcoin-json-rpc": "^1.3.3",
     "detox": "20.23.1",
     "electrum-client": "BlueWallet/rn-electrum-client#47acb51149e97fab249c3f8a314f708dbee4fb6e",
-    "eslint": "^8.57.0",
-    "eslint-plugin-ft-flow": "^3.0.7",
     "husky": "^9.1.5",
     "jest": "^29.7.0",
     "lnurl": "0.26.2",
     "nano-staged": "^0.8.0",
     "node-fetch": "^2.6.7",
     "patch-package": "^8.0.0",
-    "prettier": "^2.8.8",
     "react-native-bundle-visualizer": "^3.1.3",
     "react-native-skia-stub": "0.0.1",
     "react-native-svg-transformer": "^1.3.0",

src/AppOnboarded.tsx

@@ -36,6 +36,7 @@ const AppOnboarded = (): ReactElement => {
 	const isOnline = useAppSelector(isOnlineSelector);
 
 	// on App start
+	// biome-ignore lint/correctness/useExhaustiveDependencies: onMount
 	useEffect(() => {
 		startWalletServices({ selectedNetwork, selectedWallet });
 
@@ -49,10 +50,9 @@ const AppOnboarded = (): ReactElement => {
 		return (): void => {
 			unsubscribeFromLightningSubscriptions();
 		};
-		// onMount
-		// eslint-disable-next-line react-hooks/exhaustive-deps
 	}, []);
 
+	// biome-ignore lint/correctness/useExhaustiveDependencies: onMount
 	useEffect(() => {
 		// on AppState change
 		const appStateSubscription = AppState.addEventListener(
@@ -84,7 +84,6 @@ const AppOnboarded = (): ReactElement => {
 		return (): void => {
 			appStateSubscription.remove();
 		};
-		// onMount
 	}, [selectedNetwork]);
 
 	useEffect(() => {