Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable every configurator #908

Draft
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

marmichalski
Copy link

Howdy, @nicolas-grekas.
As suggested, here comes a basic PR allowing to disable configurators. I am opening this in a current state to see if this approach is valid and to happily work on your feedback 😅.

Closes #881.

Copy link

@lzakrzewski lzakrzewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this 👍

@nicolas-grekas
Copy link
Member

I didn't expect this approach. I don't think it makes sense to disable configurators case by case as that's going to provide broken experiences, where only part of a recipe is applied. Docker support is a bit special since that's not about the app itself.

Instead, I was expecting a single flag to disable all recipes.

(Note that this can already be achieved without patching flex by creating a recipe repo that ships no recipes.)

@marmichalski
Copy link
Author

I didn't expect this approach. I don't think it makes sense to disable configurators case by case as that's going to provide broken experiences, where only part of a recipe is applied. Docker support is a bit special since that's not about the app itself.

Okay 😢

Instead, I was expecting a single flag to disable all recipes.

Sure, I'll change this PR into single-flag-to-rule-them-all then, thanks.

@marmichalski marmichalski marked this pull request as draft May 3, 2022 08:23
@maxhelias
Copy link
Contributor

I don't see the added value even to disable all the recipes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants