Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Address layer / image extraction issues in user namespaces #2699

Merged
merged 2 commits into from
Mar 4, 2024
Merged

fix: Address layer / image extraction issues in user namespaces #2699

merged 2 commits into from
Mar 4, 2024

Commits on Mar 1, 2024

  1. fix: use rootless umoci inside user namespace 

    If we are running from within a user namespace, then use rootless OCI
layer with umoci.

This permits the extraction to complete when singularity is run under
`unshare -r`.

Part of sylabs#2698
    @dtrudg
    dtrudg committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    877b762 View commit details
    Browse the repository at this point in the history

  2. fix: honor --userns in unsquashfs wrapping 

    If singularity is executed with `--userns/-u` then where possible it
should also use a user namespace where it executes `unsquashfs` in a
wrapped manner.

Previously the `unsquashfs` wrapping was without `--userns/-u` in a
setuid installation. This caused extraction to fail from within a
non-root-mapped user namespace (e.g. `unshare -c`).

Part of sylabs#2698
    @dtrudg
    dtrudg committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    829c9fe View commit details
    Browse the repository at this point in the history