Initial migration #1
Conversation
|
@jrgnicho have you had a chance to review this PR? |
| @@ -0,0 +1,7 @@ | |||
| # ROS-Install File | |||
|
|
|||
There was a problem hiding this comment.
does opp stand for offline path planner?
There was a problem hiding this comment.
Yes. OPP had been selected before I stepped in to finish some refactoring. I would not be opposed to changing the initials to TOP (Toolpath Offline Planning), but I would rather do so in a second pull request.
| plane.origin(1) = static_cast<double>(origin.y); | ||
| plane.origin(2) = static_cast<double>(origin.z); | ||
|
|
||
| return boost::make_optional(plane); |
There was a problem hiding this comment.
I don't think calling boost::make_optional is necessary, the returned plane object will get casted into an optional I think
There was a problem hiding this comment.
I'm not sure whether it is necessary, I inherited this code. Either way, I think that explicitly calling make_optional makes it more clear what is happening. I generally prefer fewer 'implied' or 'behind-the-screen' castings.
DavidMerzJr
force-pushed
the
initial-migration
branch
from
b3b268b
to
de344a8
Compare
|
@jrgnicho I have made changes to address your above requests. |
opp_msgs_serialization/include/opp_msgs_serialization/binary_serialization.h
Outdated
Show resolved
Hide resolved
opp_msgs_serialization/include/opp_msgs_serialization/eigen_yaml.h
Outdated
Show resolved
Hide resolved
opp_gui/include/opp_gui/widgets/polygon_area_selection_widget.h
Outdated
Show resolved
Hide resolved
opp_gui/include/opp_gui/widgets/segmentation_parameters_editor_widget.h
Outdated
Show resolved
Hide resolved
| #include "opp_gui/utils.h" | ||
| #include "opp_gui/widgets/tool_path_editor_widget.h" | ||
| #include "opp_gui/widgets/touch_point_editor_widget.h" | ||
| #include "ui_tool_path_planner.h" |
There was a problem hiding this comment.
Is this header in the same directory?
There was a problem hiding this comment.
Never mind, I just realized this is the automatically generated header from the ui file
These packages have been in internal development at SwRI under the Apache License for several months. These commits represent the prep for release of a number of those packages in a cleaned-up, stripped-down manner. This is a clean "starting over" point, from which these packages can hopefully grow into a highly useful open-source tool.