Changing hard coded default port value and improving string allocation

swri-robotics · May 10, 2024 · a5e53b0 · a5e53b0
1 parent d3f7d23
commit a5e53b0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/gpsd_client/src/client.cpp b/gpsd_client/src/client.cpp
@@ -48,12 +48,12 @@ namespace gpsd_client
       publish_period_ms = std::chrono::milliseconds{(int)(1000 / publish_rate_)};
 
       std::string host = "localhost";
-      int port = 2947;
+      int port = atoi(DEFAULT_GPSD_PORT);
       this->get_parameter_or("host", host, host);
       this->get_parameter_or("port", port, port);
 
       char port_s[12];
-      snprintf(port_s, 12, "%d", port);
+      snprintf(port_s, sizeof(port_s), "%d", port);
 
       gps_data_t* resp = nullptr;