This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Feature/env init Magento cloud update #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergin back
…ting stores.php as well
…ting stores.php as well
navarr
suggested changes
Nov 15, 2022
Comment on lines
+1
to
+4
| function :: { | ||
| echo | ||
| echo "==> [$(date +%H:%M:%S)] $@" | ||
| } |
There was a problem hiding this comment.
We don't currently use this pattern anywhere, so I'm not sure we should start adopting it now
If we were, it should also be in the utility file - not in the individual command
There was a problem hiding this comment.
yeah, it makes sense.. let me remove it... I got the idea from here: https://github.com/davidalger/warden-env-magento2/blob/develop/.warden/commands/bootstrap.cmd
| function createEnvPhpFile { | ||
| mkdir -p app/etc | ||
| ENV_PHP=$(magento-cloud ssh --project=$PROJECT --environment=$ENVIRONMENT php <<CODE | ||
| <?Php |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates to
den env-init name magento-cloudcommand.magento2-config.envin it)