Emit references to shadowed variables in if-let shorthands #77177
+49
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es when indexing locals is enabled. Track the original-decl/captured decl as part of the symbol passed to the IndexConsumer. This allows the Rename consumer to check if the symbol is a shadowed reference to a decl being renamed, without the index skipping the other relevant output when visiting shadowing variables. swiftlang#76805
dylansturg
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
bnbarham
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Thanks for working through this @dylansturg 🙇♂️. LGTM assuming all the other tests pass!
|
The failure for macOS seems unrelated. It looks like the build at head is failing with the same error; looking at https://ci.swift.org/job/oss-swift-incremental-RA-macos/. Hopefully that's resolved soon and we can retry. |
|
@swift-ci please test macOS |
hamishknight
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables defined in if-let shorthand now get their own definition and references to the variable use that definition.
Track the original-decl/captured decl as part of the symbol passed to the IndexConsumer. This allows the Rename consumer to check if the symbol is a shadowed reference to a decl being renamed, without the index skipping the other relevant output when visiting shadowing variables.
This change stores variables from if-let shorthand syntax in the indexstore, when indexing locals, because those are local variables too. As opposed to purely being references to their shadowed declaration.
Resolves #76805