Sema: Undo changes in chronological order in SolverTrail::undo() #77174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions are never called while undoing a change; so we want to assert if we have an active undo instead of silently not recording the change.
xedin
reviewed
Oct 22, 2024
| void ConstraintGraphNode::reintroduceToInference(Constraint *constraint) { | ||
| retractFromInference(constraint); | ||
| introduceToInference(constraint); | ||
| void ConstraintGraphNode::retractFromInference(Type fixedType) { |
There was a problem hiding this comment.
Looks like the logic in retractFromInference(Type) and introduceToInference could be unified into a method i.e. updateAfterBind` that would accept a callback that either introduces or retracts constraints...
xedin
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
LGTM! I feel like dealing with constraints after binding a type variable is an overkill, we might get away with keeping the set as is but using simplifyType during BindingSet construction because all of the logic to compute flags (i.e. pontential incomplete, literal, delayed etc.) moved there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a loose end from my SolverScope refactoring.