Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform-specific branches for FreeBSD. #685

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Sep 12, 2024

This PR adds support for FreeBSD where we have platform-specific code. Most changes simply involve changing os(Linux) to os(Linux) || os(FreeBSD), although there is some actual platform-specific code and at least one spot where Darwin and FreeBSD share an implementation but Linux does not.

Note

This new code is minimally tested. Support for FreeBSD is provided by the Swift community.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added enhancement New feature or request help wanted Extra attention is needed freebsd 😈 FreeBSD support labels Sep 12, 2024
@grynspan grynspan self-assigned this Sep 12, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

This PR adds support for FreeBSD where we have platform-specific code. Most
changes simply involve changing `os(Linux)` to `os(Linux) || os(FreeBSD)`,
although there is some actual platform-specific code and at least one spot where
Darwin and FreeBSD share an implementation but Linux does not.

> [!NOTE]
> This new code is minimally tested. The Swift project does not officially
> support FreeBSD.
@grynspan
Copy link
Contributor Author

@swift-ci test

Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified at least this doesn't break WASI build

@grynspan grynspan merged commit fdbfff0 into main Sep 12, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/freebsd branch September 12, 2024 20:35
grynspan added a commit that referenced this pull request Sep 17, 2024
Follow-up to #685. Add links to FreeBSD manpages on freebsd.org for the header
files we mention in our exit test documentation.
grynspan added a commit that referenced this pull request Sep 17, 2024
Follow-up to #685. Add links to FreeBSD manpages on freebsd.org for the
header files we mention in our exit test documentation.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
@grynspan grynspan added this to the Swift 6.1 milestone Sep 20, 2024
@grynspan
Copy link
Contributor Author

Refined by #865 and #867.

@grynspan grynspan mentioned this pull request Dec 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request freebsd 😈 FreeBSD support help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants