-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform-specific branches for FreeBSD. #685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
New feature or request
help wanted
Extra attention is needed
freebsd
😈 FreeBSD support
labels
Sep 12, 2024
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
September 12, 2024 13:38
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/freebsd
branch
from
September 12, 2024 13:41
a6e9bdd
to
a590d1e
Compare
grynspan
commented
Sep 12, 2024
This PR adds support for FreeBSD where we have platform-specific code. Most changes simply involve changing `os(Linux)` to `os(Linux) || os(FreeBSD)`, although there is some actual platform-specific code and at least one spot where Darwin and FreeBSD share an implementation but Linux does not. > [!NOTE] > This new code is minimally tested. The Swift project does not officially > support FreeBSD.
grynspan
force-pushed
the
jgrynspan/freebsd
branch
from
September 12, 2024 13:54
a590d1e
to
b844a3e
Compare
@swift-ci test |
grynspan
commented
Sep 12, 2024
kateinoigakukun
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified at least this doesn't break WASI build
compnerd
approved these changes
Sep 12, 2024
stmontgomery
approved these changes
Sep 12, 2024
grynspan
added a commit
that referenced
this pull request
Sep 17, 2024
Follow-up to #685. Add links to FreeBSD manpages on freebsd.org for the header files we mention in our exit test documentation.
2 tasks
grynspan
added a commit
that referenced
this pull request
Sep 17, 2024
Follow-up to #685. Add links to FreeBSD manpages on freebsd.org for the header files we mention in our exit test documentation. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for FreeBSD where we have platform-specific code. Most changes simply involve changing
os(Linux)
toos(Linux) || os(FreeBSD)
, although there is some actual platform-specific code and at least one spot where Darwin and FreeBSD share an implementation but Linux does not.Note
This new code is minimally tested. Support for FreeBSD is provided by the Swift community.
Checklist: