-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SwiftParser] Support function body and type member skipping #2316
Draft
rintaro
wants to merge
4
commits into
swiftlang:main
Choose a base branch
from
rintaro:parser-skipbody
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2014 - 2023 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
@_spi(RawSyntax) import SwiftSyntax | ||
|
||
extension Parser { | ||
mutating func skippedFunctionBody() -> RawSkippedDeclSyntax? { | ||
return self.skippedBraceBody(while: { tokenKind, tokenText in | ||
// If the function body contains a type decl, don't skip. | ||
if tokenKind == .keyword && ( | ||
tokenText == "enum" || | ||
tokenText == "struct" || | ||
tokenText == "class" || | ||
tokenText == "actor" | ||
) { | ||
return false | ||
} | ||
return true | ||
}) | ||
} | ||
|
||
mutating func skippedMemberBody() -> RawSkippedDeclSyntax? { | ||
var lastTokenWasFunc: Bool = false | ||
return self.skippedBraceBody(while: { tokenKind, tokenText in | ||
|
||
// '#' directives. | ||
if tokenKind == .poundIf || tokenKind == .poundSourceLocation { | ||
return false | ||
} | ||
|
||
// Nested class. Because? | ||
if tokenKind == .keyword && tokenText == "class" { | ||
return false | ||
} | ||
|
||
// Operator functions. Because they're visible from top-level. | ||
if lastTokenWasFunc && ( | ||
tokenKind == .binaryOperator || tokenKind == .prefixOperator || tokenKind == .postfixOperator | ||
) { | ||
return false | ||
} | ||
lastTokenWasFunc = tokenKind == .keyword && tokenText == "func" | ||
|
||
return true | ||
}) | ||
} | ||
|
||
fileprivate mutating func skippedBraceBody(while condition: (_ tokenKind: RawTokenKind, _ tokenText: SyntaxText) -> Bool) -> RawSkippedDeclSyntax? { | ||
return self.withLookahead { lookahead in | ||
guard lookahead.advanceUntilMatchingRightBrace(while: condition) == .reachedToEnd else { | ||
return nil | ||
} | ||
|
||
// Skipped region as a single SyntaxText. | ||
let wholeText = SyntaxText( | ||
baseAddress: self.currentToken.start, | ||
count: self.currentToken.start.distance(to: lookahead.currentToken.start) | ||
) | ||
|
||
// Advance the Lexer to skipped position. | ||
self.currentToken = lookahead.currentToken | ||
self.lexemes = lookahead.lexemes | ||
|
||
// Represent the skipped range with a single .unknown token. | ||
let tok = RawTokenSyntax( | ||
kind: .unknown, | ||
wholeText: wholeText, | ||
textRange: wholeText.startIndex..<wholeText.endIndex, | ||
presence: .present, | ||
tokenDiagnostic: nil, | ||
arena: self.arena | ||
) | ||
return RawSkippedDeclSyntax(text: tok, arena: self.arena) | ||
} | ||
} | ||
} | ||
|
||
fileprivate extension Parser.Lookahead { | ||
enum SkipBodyResult { | ||
case aborted | ||
case reachedToEnd | ||
} | ||
|
||
mutating func advanceUntilMatchingRightBrace(while condition: (_ tokenKind: RawTokenKind, _ tokenText: SyntaxText) -> Bool) -> SkipBodyResult { | ||
var openBraces = 1 | ||
|
||
while self.currentToken.rawTokenKind != .endOfFile { | ||
let tokenKind = currentToken.rawTokenKind | ||
let tokenText = currentToken.tokenText | ||
|
||
guard condition(tokenKind, tokenText) else { | ||
return .aborted | ||
} | ||
|
||
if tokenKind == .leftBrace { | ||
openBraces += 1 | ||
} else if tokenKind == .rightBrace { | ||
openBraces -= 1 | ||
if openBraces == 0 { | ||
break | ||
} | ||
} | ||
self.consumeAnyToken() | ||
} | ||
|
||
return .reachedToEnd | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because of AnyObject lookup :shakesfist: