Enable UseSynthesizedInitializer and remove redundant initializers.

swiftlang · Oct 2, 2024 · 3390fcf · 3390fcf
1 parent f4acb89
commit 3390fcf
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 31 deletions.
diff --git a/.swift-format b/.swift-format
@@ -13,6 +13,6 @@
         "NoBlockComments": false,
         "OrderedImports": true,
         "UseLetInEveryBoundCaseVariable": false,
-        "UseSynthesizedInitializer": false
+        "UseSynthesizedInitializer": true
     }
 }
diff --git a/Sources/SwiftCompilerPlugin/CompilerPlugin.swift b/Sources/SwiftCompilerPlugin/CompilerPlugin.swift
@@ -96,9 +96,7 @@ struct CompilerPluginError: Error, CustomStringConvertible {
 
 struct MacroProviderAdapter<Plugin: CompilerPlugin>: PluginProvider {
   let plugin: Plugin
-  init(plugin: Plugin) {
-    self.plugin = plugin
-  }
+
   func resolveMacro(moduleName: String, typeName: String) throws -> Macro.Type {
     try plugin.resolveMacro(moduleName: moduleName, typeName: typeName)
   }

diff --git a/Sources/SwiftCompilerPluginMessageHandling/PluginMessages.swift b/Sources/SwiftCompilerPluginMessageHandling/PluginMessages.swift
@@ -208,19 +208,9 @@ public enum PluginMessage {
       public struct Change: Codable {
         public var range: PositionRange
         public var newText: String
-
-        internal init(range: PositionRange, newText: String) {
-          self.range = range
-          self.newText = newText
-        }
       }
       public var message: String
       public var changes: [Change]
-
-      internal init(message: String, changes: [Change]) {
-        self.message = message
-        self.changes = changes
-      }
     }
     public var message: String
     public var severity: Severity

diff --git a/Sources/SwiftParser/CharacterInfo.swift b/Sources/SwiftParser/CharacterInfo.swift
@@ -14,10 +14,6 @@ extension Character {
   fileprivate struct Info: OptionSet {
     var rawValue: UInt8
 
-    init(rawValue: UInt8) {
-      self.rawValue = rawValue
-    }
-
     static let IDENT_START: Self = .init(rawValue: 0x01)
     static let IDENT_CONT: Self = .init(rawValue: 0x02)
     static let DECIMAL: Self = .init(rawValue: 0x04)

diff --git a/Sources/SwiftParser/Declarations.swift b/Sources/SwiftParser/Declarations.swift
@@ -161,11 +161,6 @@ extension Parser {
   struct DeclAttributes {
     var attributes: RawAttributeListSyntax
     var modifiers: RawDeclModifierListSyntax
-
-    init(attributes: RawAttributeListSyntax, modifiers: RawDeclModifierListSyntax) {
-      self.attributes = attributes
-      self.modifiers = modifiers
-    }
   }
 
   /// Parse a declaration.

diff --git a/Sources/SwiftParser/Statements.swift b/Sources/SwiftParser/Statements.swift
@@ -816,14 +816,6 @@ extension Parser {
   struct StatementLabel {
     var label: RawTokenSyntax
     var colon: RawTokenSyntax
-
-    init(
-      label: RawTokenSyntax,
-      colon: RawTokenSyntax
-    ) {
-      self.label = label
-      self.colon = colon
-    }
   }
 
   /// Parse an optional label that defines a named control flow point.