Attempt two at solving Windows symbol linking issues #8117
+37
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts the prevous attempt at fixing symbol export errors in EXEs. Instead, for Windows triples, we mark all targets as needing to be static. Then, after the products are planned, walks throught the staticTargets of DLL products and marks as not static. This allows executables in packages to import modules in local DLL products as exporting. This is a temporary fix until we add the ability for targets to explicity depend on local products.
Doing recursive deps brought back the exported a symbol you imported warnings.
This will happen when a module that exports a symbol for a DLL is also linked into an EXE with modules that import it.
dschaefer2
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
jakepetroules
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating two modules, one that exports symbols and one that doesn't and letting consuming products pick which one they want, we now mark all targets on Windows as static and then reset that if a target is in a DLL product. This gets by the missing feature of marking a target as a DLL (only products can be DLLs).
We also turn off the exporting imported symbol warning that is generated when a module in a DLL is also used in a static context confusing the linker.